Add support for a declaration attribute @warn for source-level warning group behavior control
#85036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
efeb7d8 to
f2090a1
Compare
artemcm
changed the title
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
2 times, most recently
from
b5ce4d2 to
f166258
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
4 times, most recently
from
f346cd4 to
213b207
Compare
artemcm
requested review from
CodaFi,
DougGregor,
bnbarham,
hamishknight,
hborla,
rintaro,
slavapestov,
tshortli,
xedin and
xymus
as code owners
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
2 times, most recently
from
09ccd1f to
b22b692
Compare
DougGregor
reviewed
Nov 7, 2025
|
|
||
| std::optional<StringRef> reasonText = std::nullopt; | ||
| if (!reason.getIsEmpty()) | ||
| reasonText = reason.unbridged(); |
Member
There was a problem hiding this comment.
Don't we need to copy this string into the ASTContext?
Contributor
Author
There was a problem hiding this comment.
Good catch, thank you.
…ing group behavior control
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
b22b692 to
693aeae
Compare
Contributor
Author
…nostic Unified across module-wide configuration flags (`-Wwarning`, `-Werror`, etc.) and syntactic configuration attribute `@warn`.
artemcm
force-pushed
the
AddSupportForWarnAttr
branch
from
693aeae to
72a0e52
Compare
Contributor
Author
artemcm
changed the title
@warn for source-level warning group behavior control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes/commits:
Add parsing for an experimental declaration attribute '@warn' for source-level warning group behavior control. This attribute is gated behind an experimental feature
SourceWarningControl.Implement support for unified warning group behavior queries per-diagnostic-group:
-Wwarningand-Werrorflags, as well asDefaultIgnorediagnostic groups to be captured as aWarningGroupBehaviorRule(as opposed to a priorWarningAsErrorRule) and replace the corresponding diagnostic group ID-indexed bit vectors inDiagnosticEnginewith with a dictionary keyed by the diagnostic group ID with values representing behavior specification rules (such asAsError,AsWarning,Ignored).SwiftWarningControlSwiftSyntax library for a given warning diagnostic's diagnostic group's emission behavior at the diagnostic's source location, as determined by syntactic@warncontrols. (Implemented inASTGen/WarningGroupBehaviorConfiguration.swift).SwiftWarningControlquery as global control inputs. This means the same query will take into account both global warning control rules specified on the command-line, as well as source-location-specific containing@warnattribute controls.ExportedSourceFile, the first query ofwarningGroupBehaviorAtPositionwill result in construction of aWarningControlRegionTreedata-structure which will be cached in theExportedSourceFileit belongs to and re-used for future queries.