Skip to content

[6.2] Only clear exit test ID env var upon successful lookup #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

[6.2] Only clear exit test ID env var upon successful lookup #1227

merged 1 commit into from
Jul 16, 2025

Conversation

@stmontgomery
Copy link
Contributor

@stmontgomery stmontgomery commented Jul 16, 2025

  • Explanation: This changes the logic in ExitTest.findInEnvironmentForEntryPoint() to only clear the environment variable containing the ID of the exit test to run if an exit test is successfully located.
  • Scope: Affects exit tests and tools that integrate with them.
  • Issues: Motivated by rdar://153326967
  • Original PRs: Only clear exit test ID env var upon successful lookup #1226
  • Risk: Low
  • Testing: Manual verification
  • Reviewers: @grynspan, @briancroom

@stmontgomery stmontgomery added this to the Swift 6.2 milestone Jul 16, 2025
@stmontgomery stmontgomery self-assigned this Jul 16, 2025
@stmontgomery stmontgomery added the enhancement New feature or request label Jul 16, 2025
@stmontgomery stmontgomery added the tools integration 🛠️ Integration of swift-testing into tools/IDEs label Jul 16, 2025
@stmontgomery stmontgomery added exit-tests ☠️ Work related to exit tests integration ⚙️ Integrating work to release branches labels Jul 16, 2025
@stmontgomery
Copy link
Contributor Author

stmontgomery commented Jul 16, 2025

@swift-ci please test

@stmontgomery stmontgomery merged commit 6952004 into swiftlang:release/6.2 Jul 16, 2025
3 checks passed
@stmontgomery stmontgomery deleted the clear-exit-test-env-var-6.2 branch July 16, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briancroom briancroom briancroom approved these changes

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@stmontgomery stmontgomery

Labels

enhancement New feature or request exit-tests ☠️ Work related to exit tests integration ⚙️ Integrating work to release branches tools integration 🛠️ Integration of swift-testing into tools/IDEs

Projects

None yet

Milestone

Swift 6.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stmontgomery @briancroom