Skip to content

Add a temporary package product that builds our cross-import overlays. #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

Add a temporary package product that builds our cross-import overlays. #1197

merged 1 commit into from
Jul 2, 2025

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Jul 2, 2025 •
edited
Loading

This PR adds a temporary product to our package that builds the cross-import overlay targets needed for image attachment support. This allows developers to try out this new code.

This product will be removed from the package in a future update.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Add a temporary package product that builds our cross-import overlays.
a1aec00 
This PR adds a **temporary** product to our package that builds the cross-import
overlay targets needed for image attachment support. This allows developers to
try out this new code.

This product will be removed from the package in a future update.
@grynspan grynspan added this to the Swift 6.x (main) milestone Jul 2, 2025
@grynspan grynspan self-assigned this Jul 2, 2025
@grynspan grynspan added darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support workaround Workaround for an issue in another component (may need to revert later) build 🧱 Affects the project's build configuration or process attachments/activities 🖇️ Work related to attachments and/or activities labels Jul 2, 2025
stmontgomery
stmontgomery reviewed Jul 2, 2025
View reviewed changes
@grynspan
Copy link
Contributor Author

grynspan commented Jul 2, 2025

@swift-ci test

@grynspan grynspan requested a review from stmontgomery July 2, 2025 19:47
@grynspan
Copy link
Contributor Author

grynspan commented Jul 2, 2025

macOS CI is jammed up. Merging before it completes. Tested at desk.

@grynspan grynspan merged commit 0022e29 into main Jul 2, 2025
2 of 3 checks passed
@grynspan grynspan deleted the jgrynspan/image-attachments-product branch July 2, 2025 20:03
@grynspan grynspan added the image-attachments 📸 Work related to image attachments label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff

Assignees

@grynspan grynspan

Labels

attachments/activities 🖇️ Work related to attachments and/or activities build 🧱 Affects the project's build configuration or process darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support image-attachments 📸 Work related to image attachments workaround Workaround for an issue in another component (may need to revert later)

Projects

None yet

Milestone

Swift 6.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@grynspan @stmontgomery