Remove withKnownIssue Amazon Linux 2 clauses #9355
Open
+30
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These issues no longer occur as a fix for linking was submitted that affects AL2 and the gold linker. * Remove the withKnownIssue clauses for AL2 On failing tests.
kcieplak
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
owenv
approved these changes
Nov 10, 2025
bkhouri
reviewed
Nov 10, 2025
Contributor
bkhouri
left a comment
bkhouri
left a comment
There was a problem hiding this comment.
We really need an Amazon Linux 2 self hosted pipeline to validate this.
@shahmishal : is this something we can add relatively quickly?
bkhouri
reviewed
Nov 10, 2025
| #expect(output.contains("No breaking changes detected in Qux")) | ||
| } | ||
| } when : { | ||
| buildSystem == .swiftbuild && ProcessInfo.isHostAmazonLinux2() |
Contributor
There was a problem hiding this comment.
Question: is the "isAmazonLinux2()" function used anywhere else? Can we remove it if not?
Contributor
There was a problem hiding this comment.
I'd leave it for now, in case we need it again in the near future.
jakepetroules
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These issues no longer occur as a fix for linking was submitted that affects AL2 and the gold linker.
swiftlang/swift-build#892
Tests are no longer recording known issues causing test failures.