Avoid expensive string array operations when performing isDescendent checks on AbsolutePath #9351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checks on AbsolutePath
rconnell9
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
plemarquand
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS smoke test |
Contributor
Author
|
@swift-ci test macOS |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
1 similar comment
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows self hosted |
Contributor
Author
|
@swift-ci test windows |
owenv
reviewed
Nov 10, 2025
| return false | ||
| } | ||
|
|
||
| if ancestorPath.hasSuffix("/") { |
Contributor
There was a problem hiding this comment.
AFAICT pathString will have windows separators on Windows, which this won't match
Contributor
Author
There was a problem hiding this comment.
I originally thought they may all be normalized to "/" by TSC.
| /// | ||
| /// This method is strictly syntactic and does not access the file system | ||
| /// in any way. | ||
| public func isDescendant(of ancestor: AbsolutePath) -> Bool { |
Contributor
There was a problem hiding this comment.
Might be worth renaming this to isSyntacticDescendant of since at a glance it looks like it's being misused in a few places where we should be considering symlinks, etc.
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid expensive string array operations when performing isDescendent checks on AbsolutePath
Motivation:
#9304
Modifications:
Rely on path normalization and perform standard prefix checks.