[cxx-interop] Add driver support for -emit-clang-header-min-access
#2010
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
j-hui
approved these changes
Nov 7, 2025
artemcm
reviewed
Nov 7, 2025
Sources/SwiftOptions/Options.swift
Outdated
| public static let emitClangHeaderMinAccess: Option = Option("-emit-clang-header-min-access", .separate, attributes: [.frontend, .noInteractive, .argumentIsPath, .cacheInvariant], metaVar: "<access-level>", helpText: "The minimum access level of declarations to include in the emitted header.>") | ||
| public static let emitClangHeaderNonmodularIncludes: Option = Option("-emit-clang-header-nonmodular-includes", .flag, attributes: [.frontend, .noInteractive, .supplementaryOutput], helpText: "Augment emitted Objective-C header with textual imports for every included modular import") | ||
| public static let emitClangHeaderPath: Option = Option("-emit-clang-header-path", .separate, alias: Option.emitObjcHeaderPath, attributes: [.frontend, .noInteractive, .argumentIsPath, .supplementaryOutput, .cacheInvariant], helpText: "Emit an Objective-C and C++ header file to <path>") | ||
| public static let emitClangHeaderMinAccess: Option = Option("-emit-clang-header-min-access", .separate, attributes: [.frontend, .noInteractive, .cacheInvariant], metaVar: "<access-level>", helpText: "The minimum access level of declarations to include in the emitted header") |
Contributor
There was a problem hiding this comment.
Just in case: please ensure Options.swift is updated as follows:
https://github.com/swiftlang/swift-driver?tab=readme-ov-file#rebuilding-optionsswift
Contributor
Author
There was a problem hiding this comment.
Oh, I somehow missed that this file is generated. Thanks!
artemcm
requested changes
Nov 7, 2025
| try commandLine.appendLast(.clangBuildSessionFile, from: &parsedOptions) | ||
| } | ||
|
|
||
| try commandLine.appendLast(.emitClangHeaderMinAccess, from: &parsedOptions) |
Contributor
There was a problem hiding this comment.
Please add a check to ensure we don't pass this flag to a compiler which does not support it.
Suggested change
| try commandLine.appendLast(.emitClangHeaderMinAccess, from: &parsedOptions) | |
| if isFrontendArgSupported(.emitClangHeaderMinAccess) { | |
| try commandLine.appendLast(.emitClangHeaderMinAccess, from: &parsedOptions) | |
| } |
egorzhdan
force-pushed
the
egorzhdan/clang-access-flag
branch
from
45ac397 to
b5fdd40
Compare
This is a counterpart to swiftlang/swift#84816. rdar://159211965
egorzhdan
force-pushed
the
egorzhdan/clang-access-flag
branch
from
b5fdd40 to
051e803
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a counterpart to swiftlang/swift#84816.
rdar://159211965