Create new target for common code #1331
Open
+204
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
I'm marking this as a draft while I perform a bit more compatibility testing to know if it's fine to move these public types or if we should leave a public typealias to these types instead? |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
I found that we needed to add |
Contributor
Author
|
@swift-ci please test |
d-ronnqvist
force-pushed
the
create-target-for-common-code
branch
from
607d02e to
04d9cc1
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This extracts the
SourceLanguagetypeand theinto a new "Common" target.SynchronizedtypeThe purpose of this change is to make it easier for other new code to be written in other new special purpose targets. And to be able to adopt stricter compile time checks in some new code that we can't yet enable in the full
SwiftDocCtarget.Dependencies
None.
Testing
Nothing in particular. This isn't a user facing
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/testscript and it succeeded[ ] Updated documentation if necessary