forked from swiftlang/swift-docker
-
Notifications
You must be signed in to change notification settings - Fork 1
Android API 23 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Android API 23 #16
Changes from 91 commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
5f1dbac
Add Android workflow
marcprux 1b7e52f
Merge branch 'swiftlang:main' into main
marcprux c263e80
Merge branch 'swiftlang:main' into main
marcprux dd6d09f
Merge branch 'swiftlang:main' into main
marcprux 6565052
Build Android image (#1)
marcprux 5f9dab4
Merge branch 'swiftlang:main' into main
marcprux 412e6b0
Merge branch 'swiftlang:main' into main
marcprux 40733f7
Swift Android build 6.2 (#2)
marcprux 53e361a
Swift Android build 6.2 (#3)
marcprux 72964f5
Build SDK in Docker container (#4)
marcprux 9160168
Merge branch 'swiftlang:main' into main
marcprux 4987bcc
Checkout patches repo instead of using a git submodule
marcprux ff3f274
Update libcurl to 8.13.0
marcprux 595efc3
Remove resources that we no longer use
marcprux 27b1bf4
Update libcurl to 8.13.0
marcprux b898129
Update libxml2 to 2.14.2
marcprux f566b23
Build libxml2, libcurl, and boringssl with support for Android 16kb p…
marcprux 529e3f1
Add build-script --extra-cmake-options=-DCMAKE_EXTRA_LINK_FLAGS=-Wl,-…
marcprux c82587d
Add 16KB page size linker flags to linker flags in swift-toolset.json
marcprux 217f1d7
Add 16KB page size linker flags to linker flags in swift-toolset.json
marcprux 95046b3
Build with ndk-r28b
marcprux 8b18b5f
Revert to building with ndk-r27c
marcprux f67f9bf
Use official endpoints for discovering latest Swift release/devel/tru…
marcprux 7011a45
Typo fix in version script
marcprux 4c65a93
Cleanup for PR
marcprux d80c80b
Change BUILD_VERSION to BUILD_SCHEME and have it match release, swift…
marcprux 2c07eef
Update Android README
marcprux 51d93f8
Update how patches are applied
marcprux 46a06df
Fix source directory for patch target
marcprux afb2918
Harmonize timestamps in artifactbundle with the swift source tag date…
marcprux a469e85
Simplify toolchain-vars.sh
marcprux dea39d7
Merge branch 'swiftlang:main' into main
marcprux b3cddbd
Merge branch 'swiftlang:main' into main
marcprux abd3fd1
Merge branch 'swiftlang:main' into main
marcprux ad24ea5
Merge branch 'swiftlang:main' into main
marcprux 50ba1cd
Run the compiler validation suite for Android (#8)
marcprux 71b7131
Build compiler-validated bundles from latest branch commits, not olde…
finagolfin e2f696a
Merge pull request #9 from swift-android-sdk/Testing
finagolfin 3f4cd4a
gcpd 'Update patches'
marcprux bd0df11
Update patches and build matrix
marcprux 80291aa
Disable compiler validated builds on self-hosted
marcprux 18c563f
Centralize cmake variable for 6.2 in patches, as done for trunk upstream
finagolfin ed09034
Update disabled tests
finagolfin e4a96b2
Merge branch 'main' into update-patches2
marcprux f472e9e
Try running Docker build on macOS host
marcprux 22a4320
Remove separate checks of libxml2, curl, and yams
marcprux bc3f105
Merge pull request #11 from swift-android-sdk/update-patches2
marcprux a7b303a
Remove upstreamed 6.2 branch patches
finagolfin 4ed1375
Merge branch 'swiftlang:main' into main
marcprux 3f36409
Use command-line flags to work around CMake 3.30+ linker flag bug, ra…
finagolfin f658604
Create an Android CMake toolchain file instead to cross-compile Testi…
finagolfin c9fc3d8
Install the native host LLVM tools for full compiler builds
finagolfin b881e14
Extend `--cross-compile-build-swift-tools=False` to disable building …
finagolfin 9af1d90
Don't copy any libraries from the NDK: link the NDK's clang resource …
finagolfin 5693797
Wildcard the clang version link in the post-install script in order t…
marcprux 31f00b1
Merge pull request #13 from swift-android-sdk/clang-wildcard
marcprux db10f68
Merge branch 'swiftlang:main' into main
marcprux 1221544
Switch generated shell header to use #!/usr/bin/env bash
marcprux f555f48
SBOM and nits (#14)
marcprux 7696a44
Remove upstreamed patches and turn the last modifications into perl s…
finagolfin 606ab7a
Remove self-hosted build on github CI
finagolfin 8eb982e
Remove android_build job from pull_request workflow
marcprux 534175d
Add license headers to Android build scripts
marcprux d139654
Remove unnecessary .gitignore
marcprux 510addd
Add license header to Dockerfile
marcprux ee191ee
Merge branch 'swiftlang:main' into main
marcprux 87bf6a2
Switch over to using explicit tags and branches when invoking build-d…
finagolfin 9987e54
Merge branch 'swiftlang:main' into main
marcprux 110ab52
Merge branch 'swiftlang:main' into main
marcprux 811583e
Merge branch 'swiftlang:main' into main
marcprux 3070fba
Fix build script arguments to use false instead of False due to true_…
marcprux bd87b1a
Build swift-6.2-RELEASE
marcprux ead9ba9
Apply patch from https://github.com/swiftlang/swift/pull/84061 for 6.…
marcprux 1a19b03
Update patch application for 6.2
marcprux fab74d2
Change 6.2 to perform local build
marcprux d05b59d
Change 6.2 to perform local build on ubuntu-24.04
marcprux bf5d18d
Switch back to building 6.2 from a tag
marcprux 7f71402
Switch back to building 6.2 from a tag
marcprux 233b535
Switch back to building 6.2 from a tag
marcprux f8fcf04
Build the Swift 6.2 release self-hosted with compiler validation
marcprux 2e0a326
Set minimum Android API to 24
marcprux 865e13f
Build against swift-DEVELOPMENT-SNAPSHOT-2025-10-16-
marcprux 9d14a52
Disable building libxml2 tests to handle missing glob function in And…
marcprux d7c0884
Disable building libxml2 tests to handle missing glob function in And…
marcprux be7a646
Build this PR without compiler validation
marcprux 09839a9
Build this PR without compiler validation
marcprux 19adc6b
Disable posix_spawnattr_ for Android 24
marcprux 21c5b03
Reduce Android API from 24 to 23
marcprux 069b38c
Restore Android minimum API to 24
marcprux c30a475
Add swift-nio to tests cases being run
marcprux 8c6f92c
Reduce Android API from 24 to 23
marcprux f4aa58c
Try building swift-collections
marcprux b364c93
Try testing against emulator API level 23
marcprux 6083eb1
Fix backtrace call
marcprux 18e77e8
Fail with an error for posix_spawn
marcprux 65dae50
Fix error for posix_spawn
marcprux 6b12a06
Remove temporary swift-docker Android build workflow
marcprux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch isn't necessary anymore. Swift Testing uses
dlsym()to look upbacktrace()before calling it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it is still needed for the 6.2 branch though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Derp. OK, I'll put it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but remove it for main! 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaning?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get this patch out of the way now, then revisit if needed when we add
#availableto the mix. I don't like having an official toolchain that isn't building from actual source. Makes for spooky bugs I can't diagnose or fix.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, we have much bigger problems with Testing, as any Swift package with macros sees strange build errors when cross-compiling, swiftlang/swift-package-manager#8094, so I wouldn't worry about many using Testing until that is fixed. 😉 We will probably have to add doc telling people to only use XCTest on Android until then.
As for this change, rather than putting in logic to check both scheme and tag names that use 6.2 and only applying this change then, let's decide after the next trunk tag, when people can try the new
#available(Androidfeature on their code finally, if we want to submit that new feature for 6.2. If not, I guarantee you that I will elide this change for 6.3 alone before the branch in a couple weeks. 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely don't want to tell people to only use XCTest! Given that Swift Testing is part of the toolchain, there should be no reason a developer who can use XCTest can't use Swift Testing.
But okay, I'll stop complaining until after the next tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that long-standing issue with cross-compiling macros for tests, I don't see any way around warning Android users off Testing for now.