-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: set Root start/end to null when fragment contains only whitespace #17125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: set Root start/end to null when fragment contains only whitespace #17125
Conversation
🦋 Changeset detectedLatest commit: a81eabc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| const has_content = this.root.fragment.nodes.some( | ||
| (node) => node.type !== 'Text' || node.data.trim().length > 0 | ||
| ); | ||
| if (has_content) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, less explicit/clear and more defensive:
if (this.root.fragment.nodes.length) {
// ...
if (start <= end) {
this.root.start = start;
this.root.end = end;
} else {
// @ts-ignore
this.root.start = this.root.end = null;
}
} else {
// @ts-ignore
this.root.start = this.root.end = null;
}| "js": [], | ||
| "start": null, | ||
| "end": null, | ||
| "type": "Root", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before the fix:
"js": [],
"start": 54,
"end": 53,
"type": "Root",
This fixes a small parser bug where the AST root start/end values are invalid (
start > end) for components with script and style tags but no markup.before:
after:
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint