feat: quick fix for adding lang="ts" #2882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87daf2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It could still be considered as non-top-level if "under if block" checks failed
dummdidumm
reviewed
Nov 11, 2025
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
Some small nits but otherwise ltgm
Comment on lines
1308
to
1310
| return { | ||
| range: Range.create(startTagNameEnd, startTagNameEnd), | ||
| newText: ' lang="ts"' |
Member
There was a problem hiding this comment.
Did you mean to return here? Else we would add another one when one exist already IIUC
Suggested change
| return { | |
| range: Range.create(startTagNameEnd, startTagNameEnd), | |
| newText: ' lang="ts"' | |
| return; |
Member
Author
There was a problem hiding this comment.
It was originally going to replace the existing lang attribute. Now that I think about it, we might only be able to do it when it's lang="js", but I don't know if there are any people who actually write that. Don't suggest anything might be better.
packages/language-server/src/plugins/typescript/features/CodeActionsProvider.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2876
I also removed the old custom quick fix. There should only be very few people who are still using the typescript version that doesn't support this, and ignore our typescript version requirement in the packages.json.