Skip to content

Conversation

@hunleyd
Copy link
Contributor

@hunleyd hunleyd commented Nov 18, 2025

Introduce a conf.d directory for PostgreSQL configuration to improve modularity and organization.

Changes include:

  • Dockerfiles: Copy and chown conf.d to /etc/postgresql-custom/.
  • Ansible: Add conf.d/.gitkeep and update postgresql.conf.j2 to include conf.d.
  • Nix: Define path for conf.d and add substitution for POSTGRESQL_CONFIG_DIR.
  • run-server.sh.in: Copy conf.d to the data directory and update postgresql.conf to include it.
  • vars.yml: Append -INDATA253 to postgresql release versions.

Introduce a `conf.d` directory for PostgreSQL configuration to improve modularity and organization.

Changes include:
- Dockerfiles: Copy and chown `conf.d` to `/etc/postgresql-custom/`.
- Ansible: Add `conf.d/.gitkeep` and update `postgresql.conf.j2` to include `conf.d`.
- Nix: Define path for `conf.d` and add substitution for `POSTGRESQL_CONFIG_DIR`.
- `run-server.sh.in`: Copy `conf.d` to the data directory and update `postgresql.conf` to include it.
- `vars.yml`: Append `-INDATA253` to postgresql release versions.
* 'develop' of github.com:supabase/postgres:
  feat: reduciton of closure size for plv8 (#1925)
@hunleyd hunleyd marked this pull request as ready for review November 18, 2025 17:47
@hunleyd hunleyd requested review from a team as code owners November 18, 2025 17:47
@hunleyd
Copy link
Contributor Author

hunleyd commented Nov 19, 2025

Local testng:

  • project spawn
  • project delete
  • project pause
  • project resume
  • change GUC by adding to file in conf.d and seeing if PG picks it up
  • test various random extensions
  • upgrades
    • 15 -> 15-INDATA253
    • 15 -> 17
    • 15 -> 17-INDATA253
    • 17 -> 17-INDATA253

@hunleyd hunleyd added the enhancement New feature or request label Nov 20, 2025
@hunleyd hunleyd self-assigned this Nov 20, 2025
Copy link
Collaborator

@samrose samrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only requesting changes on the upgrade to 17.7 since you already had a PR at #1926 other than that from what I can see we can merge this

@hunleyd hunleyd requested a review from samrose November 20, 2025 21:43
Copy link
Collaborator

@samrose samrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to remove the actual upgrade to 17.7

@hunleyd hunleyd requested a review from samrose November 20, 2025 21:47
Copy link
Contributor

@jchancojr jchancojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ami on local infra (pause/resume,upgrades).

LGTM

@samrose samrose enabled auto-merge November 21, 2025 17:29
@samrose samrose added this pull request to the merge queue Nov 21, 2025
Merged via the queue into develop with commit d95ee44 Nov 21, 2025
14 checks passed
@samrose samrose deleted the INDATA-253 branch November 21, 2025 18:43
hunleyd added a commit that referenced this pull request Dec 1, 2025
* origin/develop:
  chore: bump Wrappers version to 0.5.7 (#1945)
  chore: bump versions (#1949)
  Revert "docs: create an automated changlog file that shows up in release file…" (#1948)
  chore: remove precreated Storage objects (#1911)
  refactor: Move PostgreSQL auto_explain config to conf.d (#1943)
  docs: create an automated changlog file that shows up in release files (#1793)
  fix: removing dead nix code (#1946)
  docs: expansion to help understand anatomy and code api in user here (#1944)
  fix: try to use mirror fallbacks for docker images (#1942)
  feat: need this workflow present to test (#1941)
  feat: Add PostgreSQL conf.d directory (#1929)
  [jj-spr] initial version (#1866)
  chore: upgrade supabase-admin-agent (#1935)
  fix: garbage collect after every profile intall + remove osquery (#1938)
  fix(ci): limit max-jobs of nix to 8 to prevent OOM while running nix flake check (#1933)
  Revert "fix: disable temporary Nix checks on aarch64-linux" (#1934)
  fix: adaptive retry on aws (#1917)
  fix: disable temporary Nix checks on aarch64-linux (#1930)
  feat: release orioledb with rewind functionality (#1880)
  feat: reduciton of closure size for plv8 (#1925)
hunleyd added a commit that referenced this pull request Dec 1, 2025
* origin/develop:
  refactor: Refactor PostgreSQL cron config and deprecations (#1951)
  chore: bump Wrappers version to 0.5.7 (#1945)
  chore: bump versions (#1949)
  Revert "docs: create an automated changlog file that shows up in release file…" (#1948)
  chore: remove precreated Storage objects (#1911)
  refactor: Move PostgreSQL auto_explain config to conf.d (#1943)
  docs: create an automated changlog file that shows up in release files (#1793)
  fix: removing dead nix code (#1946)
  docs: expansion to help understand anatomy and code api in user here (#1944)
  fix: try to use mirror fallbacks for docker images (#1942)
  feat: need this workflow present to test (#1941)
  feat: Add PostgreSQL conf.d directory (#1929)
  [jj-spr] initial version (#1866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants