-
Notifications
You must be signed in to change notification settings - Fork 316
feat: support append mode when updating network restrictions #4420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support append mode when updating network restrictions #4420
Conversation
Pull Request Test Coverage Report for Build 19497490251Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sweatybridge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change for those who rely on the current behaviour. Could you introduce a new --append flag to the update command instead?
|
thanks @sweatybridge. updated! |
What kind of change does this PR introduce?
API improvement
What is the current behavior?
Currently, running
network-restrictions updatewill replace all existing restrictions with the provided list. This makes it easy to wipe all existing restrictions when adding a new one.What is the new behavior?
network-restrictions updatewill now add the provided restrictions to the existing list. This matches the behavior of the "Add restriction" in the Supabase UI.