-
Notifications
You must be signed in to change notification settings - Fork 107
feat(build): x86 musl build #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
commented
Sep 18, 2025
psteinroe
approved these changes
Sep 18, 2025
juleswritescode
commented
Sep 18, 2025
packages/@postgrestools/postgrestools/scripts/generate-packages.mjs
Outdated
Show resolved
Hide resolved
…_lsp into feat/musl-build
…_lsp into feat/musl-build
…ty/postgres_lsp into feat/musl-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
muslbinary to our releases for x86 systems, which should help users with older systems withglibcversions<2.35.Building a
muslbinary for aarch64 kept failing because of our various C dependencies.According to Claude (this is not my area of expertise), this should help 95% of users, since aarch64 has only been distributed with more recent machines. Most of these recent aarch64 machines should support
glibc>=2.35, so no musl build would be necessary, anyways.Let's see I guess :)
Note: I did not test the
npmrelease, only that the binaries are built and that the packages are correct in thepackagesfolder