✨(frontend) improve mobile UX by showing subdocs count #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helps users notice root documents have children in mobile view Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
feat/1314-show-sub-docs-count
branch
from
e79dba5 to
050189f
Compare
Ovgodd
commented
Oct 30, 2025
Comment on lines
+64
to
+94
| {isDesktop ? ( | ||
| <> | ||
| <Text | ||
| $variation="600" | ||
| $size="s" | ||
| $weight="bold" | ||
| $theme={isEditable ? 'greyscale' : 'warning'} | ||
| > | ||
| {transRole( | ||
| isEditable ? doc.user_role || doc.link_role : Role.READER, | ||
| )} | ||
| · | ||
| </Text> | ||
| <Text $variation="600" $size="s"> | ||
| {dateToDisplay} | ||
| </Text> | ||
| </> | ||
| ) : ( | ||
| <> | ||
| <Text $variation="400" $size="s"> | ||
| {hasChildren ? relativeOnly : dateToDisplay} | ||
| </Text> | ||
| {hasChildren ? ( | ||
| <Text $variation="400" $size="s"> | ||
| • | ||
| {t('Contains {{count}} sub-documents', { | ||
| count: childrenCount, | ||
| })} | ||
| </Text> | ||
| ) : null} | ||
| </> |
Collaborator
Author
There was a problem hiding this comment.
@AntoLC I was hesitating to create DocHeaderInfoDesktop and DocHeaderInfoMobile components to make this component clearer and more readable. We would just have a bit of props drilling, what do you think?
Collaborator
There was a problem hiding this comment.
I think it is ok, but to improve a bit readability you can maybe do:
if(isDesktop){
return ...
}
return ...
|
Size Change: +232 B (+0.01%) Total Size: 3.68 MB
|
AntoLC
reviewed
Nov 7, 2025
Comment on lines
+86
to
+93
| {hasChildren ? ( | ||
| <Text $variation="400" $size="s"> | ||
| • | ||
| {t('Contains {{count}} sub-documents', { | ||
| count: childrenCount, | ||
| })} | ||
| </Text> | ||
| ) : null} |
Collaborator
There was a problem hiding this comment.
Suggested change
| {hasChildren ? ( | |
| <Text $variation="400" $size="s"> | |
| • | |
| {t('Contains {{count}} sub-documents', { | |
| count: childrenCount, | |
| })} | |
| </Text> | |
| ) : null} | |
| {hasChildren && ( | |
| <Text $variation="400" $size="s"> | |
| • | |
| {t('Contains {{count}} sub-documents', { | |
| count: childrenCount, | |
| })} | |
| </Text> | |
| )} |
Comment on lines
+31
to
+46
| const { data: childrenPage } = useDocChildren( | ||
| { docId: doc.id, page_size: 1 }, | ||
| { enabled: true }, | ||
| ); | ||
| const countFromTreeContext = | ||
| treeContext?.root?.id === doc.id | ||
| ? treeContext?.treeData?.nodes?.length | ||
| : undefined; | ||
|
|
||
| const childrenCount = | ||
| countFromTreeContext ?? | ||
| childrenPage?.count ?? | ||
| doc.numchild ?? | ||
| tree?.children?.length ?? | ||
| 0; | ||
|
|
Collaborator
There was a problem hiding this comment.
Do we really need all that ? Why is doc.numchild not enough ?
Comment on lines
+47
to
+51
| let dateToDisplay = t('Last update: {{update}}', { | ||
| update: relativeDate(doc.updated_at), | ||
| }); | ||
| const relativeOnly = relativeDate(doc.updated_at); | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| let dateToDisplay = t('Last update: {{update}}', { | |
| update: relativeDate(doc.updated_at), | |
| }); | |
| const relativeOnly = relativeDate(doc.updated_at); | |
| const relativeOnly = relativeDate(doc.updated_at); | |
| let dateToDisplay = t('Last update: {{update}}', { | |
| update: relativeOnly, | |
| }); | |
Comment on lines
+64
to
+94
| {isDesktop ? ( | ||
| <> | ||
| <Text | ||
| $variation="600" | ||
| $size="s" | ||
| $weight="bold" | ||
| $theme={isEditable ? 'greyscale' : 'warning'} | ||
| > | ||
| {transRole( | ||
| isEditable ? doc.user_role || doc.link_role : Role.READER, | ||
| )} | ||
| · | ||
| </Text> | ||
| <Text $variation="600" $size="s"> | ||
| {dateToDisplay} | ||
| </Text> | ||
| </> | ||
| ) : ( | ||
| <> | ||
| <Text $variation="400" $size="s"> | ||
| {hasChildren ? relativeOnly : dateToDisplay} | ||
| </Text> | ||
| {hasChildren ? ( | ||
| <Text $variation="400" $size="s"> | ||
| • | ||
| {t('Contains {{count}} sub-documents', { | ||
| count: childrenCount, | ||
| })} | ||
| </Text> | ||
| ) : null} | ||
| </> |
Collaborator
There was a problem hiding this comment.
I think it is ok, but to improve a bit readability you can maybe do:
if(isDesktop){
return ...
}
return ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve mobile user experience by indicating when a document or a subdocument has children.
issue : 1314
Proposal