Remove deprecated rule #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olemen-WittGruppe
approved these changes
Jan 5, 2024
|
We've also experienced this, could I ask what the status of this PR is please? |
domarmstrong
approved these changes
Feb 1, 2024
Author
|
I wonder if a maintainer has to approve? |
|
I've removed this package from our dependencies now, it doesn't seem like it's adding too much, the only rule that mattered to us was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line removed in this PR was deprecated in Stylelint 15 per https://github.com/stylelint/stylelint/blob/bc9225e53b2d937f1347d55766090cc6264e81a8/docs/migration-guide/to-15.md?plain=1#L66 and started erroring out for us as a missing rule in Stylelint 16.