Skip to content
This repository was archived by the owner on Dec 14, 2022. It is now read-only.

fix incorrect method getUseEarliestWhenDataLossAndRemoveKey #473

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix incorrect method getUseEarliestWhenDataLossAndRemoveKey #473

wants to merge 3 commits into from

Conversation

@gaozhangmin
Copy link
Contributor

@gaozhangmin gaozhangmin commented Nov 30, 2021

pulsar.reader.use-earliest-when-data-loss property has been transformed into useEarliestWhenDataLoss by method getPulsarProperties in readerConf.

So methdo getUseEarliestWhenDataLossAndRemoveKey should get useEarliestWhenDataLoss from readerConf instead of use-earliest-when-data-loss.

@gaozhangmin gaozhangmin requested review from a team, nlu90 and syhily as code owners November 30, 2021 08:43
@nlu90
Copy link
Contributor

nlu90 commented Dec 1, 2021

@syhily Could you also take a look?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@syhily syhily Awaiting requested review from syhily

1 more reviewer

@nlu90 nlu90 nlu90 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaozhangmin @nlu90