-
-
Notifications
You must be signed in to change notification settings - Fork 938
chore: fix JavaScript lint errors (issue #8294) #8372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
lib/node_modules/@stdlib/_tools/bib/citation-reference/lib/sync.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/_tools/eslint/rules/jsdoc-license-header-year/lib/main.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When editing this file, you needed to spend some time actually understanding what was being measured. In this case, we explicitly wanted to use new Array(...) as we were explicitly benchmarking its performance.
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after clean-up
|
@Siva-Shaw As an FYI, this PR cannot move forward and be merged until you perform the steps mentioned in the comments above. Namely, you need to acknowledge that you've read, understood, and followed the contributing guidelines. This is needed as part of our contributing guidelines is acceptance of the project's licensing terms and the developer's certificate of origin. |
Resolves #8294
Description
This pull request:
Related Issues
Resolves #8294
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers