Skip to content

fix(utils): fetch bindings #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(utils): fetch bindings #1514

wants to merge 1 commit into from

Conversation

@alexandre-abrioux
Copy link

@alexandre-abrioux alexandre-abrioux commented Nov 7, 2025 •
edited
Loading

Motivation and Resolution

When running tests with Jest using testEnvironment: "jsdom" to simulate a browser environment, globalThis is defined but globalThis.fetch is removed by Jest.

When using Starknet's Javascript library, we end up with the following error in tests:

TypeError: Cannot read properties of undefined (reading 'bind')

This is a fix to remediate that issue.

Usage related changes

N/A

Development related changes

N/A

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alexandre-abrioux