Adding CTA to news letter card #2810
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalst
requested changes
May 7, 2024
Collaborator
There was a problem hiding this comment.
- Clicking on the button makes the page jump to top. This ie because it should be a button and not a link with
href="#". Please chaneg to a button, or if it's too complicated at least addpreventDefault. - Since the whole strip is clickable, change the cursor to pointer.
TalBenAvi
temporarily deployed
to
Netlify CMS Newsletter-box-on-SN-HP
GitHub Actions
Inactive
TalBenAvi
temporarily deployed
to
Storybook Newsletter-box-on-SN-HP
GitHub Actions
Inactive
TalBenAvi
temporarily deployed
to
Starknet Website Newsletter-box-on-SN-HP
GitHub Actions
Inactive
TalBenAvi
temporarily deployed
to
Storybook Newsletter-box-on-SN-HP
GitHub Actions
Inactive
TalBenAvi
temporarily deployed
to
Starknet Website Newsletter-box-on-SN-HP
GitHub Actions
Inactive
TalBenAvi
temporarily deployed
to
Netlify CMS Newsletter-box-on-SN-HP
GitHub Actions
Inactive
igalst
approved these changes
May 8, 2024
TalBenAvi
temporarily deployed
to
Storybook Newsletter-box-on-SN-HP
GitHub Actions
Inactive
TalBenAvi
temporarily deployed
to
Netlify CMS Newsletter-box-on-SN-HP
GitHub Actions
Inactive
TalBenAvi
temporarily deployed
to
Starknet Website Newsletter-box-on-SN-HP
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.