Skip to content

Conversation

@jacinta-stacks
Copy link
Contributor

@jacinta-stacks jacinta-stacks commented Nov 18, 2025

While writing tests for RuntimeError variants, I was trying to figure out how to trigger specifically RuntimeError::MetadataAlreadySet. The only function that returns it is try_set_metadata, which was introduced in this pull request by @aaronb-stacks . It doesn't seem to actually be used anywhere though it is a public function. I could write a unit test for it specifically, but I am hoping to just remove it entirely.

Closes #6708

Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.48%. Comparing base (dd1b787) to head (b386645).
⚠️ Report is 3 commits behind head on develop.

❌ Your project status has failed because the head coverage (66.48%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6696       +/-   ##
============================================
+ Coverage    44.77%   66.48%   +21.70%     
============================================
  Files          577      577               
  Lines       357352   357339       -13     
============================================
+ Hits        159992   237560    +77568     
+ Misses      197360   119779    -77581     
Files with missing lines Coverage Δ
clarity-types/src/errors/mod.rs 74.71% <ø> (+22.98%) ⬆️
clarity/src/vm/database/clarity_db.rs 79.34% <ø> (+5.45%) ⬆️

... and 449 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1b787...b386645. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@federico-stacks federico-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt!

Copy link

@francesco-stacks francesco-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jacinta-stacks jacinta-stacks added this pull request to the merge queue Nov 19, 2025
Merged via the queue into stacks-network:develop with commit 36389fe Nov 19, 2025
604 of 620 checks passed
@jacinta-stacks jacinta-stacks deleted the chore/remove-metadata-already-set branch November 19, 2025 18:19
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants