-
Notifications
You must be signed in to change notification settings - Fork 717
Remove unused try_set_metadata #6696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused try_set_metadata #6696
Conversation
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (66.48%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6696 +/- ##
============================================
+ Coverage 44.77% 66.48% +21.70%
============================================
Files 577 577
Lines 357352 357339 -13
============================================
+ Hits 159992 237560 +77568
+ Misses 197360 119779 -77581
... and 449 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
federico-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt!
francesco-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
36389fe
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
While writing tests for
RuntimeErrorvariants, I was trying to figure out how to trigger specificallyRuntimeError::MetadataAlreadySet. The only function that returns it istry_set_metadata, which was introduced in this pull request by @aaronb-stacks . It doesn't seem to actually be used anywhere though it is a public function. I could write a unit test for it specifically, but I am hoping to just remove it entirely.Closes #6708