feat(LB): improve immutable changes error message #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in the error message if set
ske-prow
bot
added
kind/enhancement
RAPSNX
reviewed
Nov 26, 2025
Co-authored-by: Raphael Grömmer <38243306+RAPSNX@users.noreply.github.com>
RAPSNX
approved these changes
Nov 27, 2025
|
LGTM label has been added. Git tree hash: f4115bcbd646614effec321392f49440a059df6a
|
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kumm-Kai, RAPSNX The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
resultImmutableChangedstruct and include it in the error message if setextraLabelsfor existing LBsSpecial notes for your reviewer:
I also noticed that the mentioned
clusterNameparameter is not used anywhere 😅 (maybe we should already_it at the methods instead of passing it to functions that just ignore it)