Add Github CI runner proxy support #1992
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds proxy support for GitHub runners by setting a custom_env fact. The overall approach is good, but there is a critical issue in how the no_proxy variable is constructed which could cause the Ansible playbook to fail. I've provided a suggestion to fix this and make the implementation more robust.
| custom_env: | | ||
| http_proxy={{ http_proxy | default('') }} | ||
| https_proxy={{ https_proxy | default('') }} | ||
| no_proxy=localhost,127.0.0.1,127.0.0.2,{{ no_proxy | default('') | join(',') }} |
There was a problem hiding this comment.
The current implementation for no_proxy will cause an error if the no_proxy variable is not defined. The default('') filter provides an empty string, and the join filter cannot be used on a string, which will cause a fatal error during playbook execution.
I suggest constructing the full list of no_proxy entries first and then joining them. This approach fixes the error and also avoids a potential trailing comma in the no_proxy value, making it more robust.
custom_env: |
http_proxy={{ http_proxy | default('') }}
https_proxy={{ https_proxy | default('') }}
no_proxy={{ (['localhost', '127.0.0.1', '127.0.0.2'] + (no_proxy | default([]))) | join(',') }}
Conditionally define custom_env fact to leverage monolithprojects.github_actions_runner role support for setting proxy on deployed Github runners.
darmach
force-pushed
the
jd-github-ci-proxy
branch
from
6140846 to
6c9662f
Compare
Conditionally sets custom_env fact to leverage
monolithprojects.github_actions_runner role support for seting proxy for deployed Github runners.
Confirmed working on environment with mandatory proxy ONLY - it would be great if someone could give this a go in non-proxy setup. With custom_env defined monolithprojects role creates .env file in /opt/actions*... directory (per runner) which is ingested by the running runner (ran on the runner VM ,)