Skip to content

Conversation

@JasleenKaurSethi
Copy link

No description provided.

@sd109 sd109 changed the title Add authentication method to the doc Add token-based auth method to the Magnum CAPI Helm doc Jul 14, 2025
@sd109
Copy link
Member

sd109 commented Jul 14, 2025

Let's hold off merging this until the various pre-requisite changes are merged:

@Alex-Welsh
Copy link
Member

@sd109
Copy link
Member

sd109 commented Aug 13, 2025

We need those dependencies to be part of a published Azimuth release (which we are still working on) before the docs changes here are applicable so let's wait for that.

@Alex-Welsh Alex-Welsh force-pushed the JasleenKaurSethi-patch-1 branch from f4b4e85 to b8d347c Compare November 17, 2025 16:49
@Alex-Welsh
Copy link
Member

@JasleenKaurSethi is this ready to merge yet?

We should probably re-target it at stackhpc/2025.1 now and then backport it once it merges there

sd109
sd109 previously approved these changes Nov 19, 2025
@JasleenKaurSethi JasleenKaurSethi changed the base branch from stackhpc/2024.1 to stackhpc/2025.1 November 19, 2025 09:56
@JasleenKaurSethi JasleenKaurSethi dismissed sd109’s stale review November 19, 2025 09:56

The base branch was changed.

@Alex-Welsh
Copy link
Member

git fetch
git checkout JasleenKaurSethi-patch-1
git reset --hard origin/stackhpc/2025.1
git cherry-pick 8d6181f527e7572bd3c869f7f6c7319c7f861abb b8d347c2138f6a3eef83f857cd70a4ed49c83538
git push -f

If someone else does the above (and then fixes the trailing whitespace on line 91) I can approve and merge the PR

@mnasiadka
Copy link
Member

39 commits? I think something is wrong?

JasleenKaurSethi and others added 2 commits November 19, 2025 11:42
Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com>
@JasleenKaurSethi
Copy link
Author

Changed the base branch to stackhpc/2025.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size: xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants