refactor(ast): rename Formatter interface to Dialect #4208
Merged
+435
−338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the Formatter interface to Dialect and refactors Format methods to accept the dialect as a parameter instead of storing it in TrackedBuffer. **Interface Changes:** - Rename `format.Formatter` to `format.Dialect` - Change Format signature from `Format(buf *TrackedBuffer)` to `Format(buf *TrackedBuffer, d format.Dialect)` **TrackedBuffer Simplification:** - Remove `formatter` field from TrackedBuffer struct - TrackedBuffer is now a simple strings.Builder wrapper - NewTrackedBuffer() no longer takes a dialect parameter **Method Call Updates:** - `buf.astFormat(x)` → `buf.astFormat(x, d)` - `buf.join(x, sep)` → `buf.join(x, d, sep)` - Helper methods now called directly on dialect: - `buf.QuoteIdent(x)` → `d.QuoteIdent(x)` - `buf.TypeName(ns, name)` → `d.TypeName(ns, name)` - `buf.Param(n)` → `d.Param(n)` - `buf.Cast(arg, t)` → `d.Cast(arg, t)` - `buf.NamedParam(name)` → `d.NamedParam(name)` This change makes the dialect dependency explicit in Format methods and simplifies TrackedBuffer to be purely a buffer utility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Formatterinterface toDialectfor better semantic clarityFormatmethods to accept dialect as a parameter instead of storing it inTrackedBufferTrackedBufferto be a pure buffer utility without dialect dependencyKey Changes
Interface Rename:
format.Formatter→format.DialectFormat Method Signature:
Format(buf *TrackedBuffer)Format(buf *TrackedBuffer, d format.Dialect)TrackedBuffer Simplification:
formatterfield - TrackedBuffer is now just astrings.BuilderwrapperNewTrackedBuffer()no longer takes a dialect parameterMethod Call Updates:
buf.astFormat(x)→buf.astFormat(x, d)buf.join(x, sep)→buf.join(x, d, sep)d.QuoteIdent(),d.TypeName(),d.Param(),d.Cast(),d.NamedParam()Rationale
The name "Dialect" better describes what this interface represents - SQL dialect-specific formatting behavior. Making the dialect an explicit parameter to Format methods:
Test plan
TestFormattests passTestReplaytests passgo test ./...tests pass🤖 Generated with Claude Code