feat(sqlite): add SQLite support to format tests #4207
Merged
+251
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements comprehensive formatting support for SQLite SQL statements, enabling round-trip format testing similar to MySQL. Key changes: **New SQLite Formatter:** - Add format.go implementing Formatter interface for SQLite dialect - Support SQLite-specific named parameter syntax (`:name` instead of `@name`) **AST Formatting Fixes:** - Add `NamedParam` method to Formatter interface for dialect-specific named params - Fix `CollateExpr` missing Format method for COLLATE clause support - Add `DefaultValues` field to InsertStmt for INSERT DEFAULT VALUES syntax - Fix table function argument conversion (e.g., json_each()) **SQLite Parser Improvements:** - Fix BoolExpr Boolop field for AND/OR expressions - Add EXISTS/NOT EXISTS subquery handling via SubLink nodes - Add unary expression support (NOT operator) - Fix NULL literal conversion in COALESCE expressions **Test Updates:** - Add SQLite case to fmt_test.go with case-insensitive fingerprinting - Regenerate expected output for select_exists/select_not_exists tests (EXISTS now correctly returns bool instead of int64) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
format.goimplementing the Formatter interface with proper named parameter syntax (:name)Key Changes
Formatter Interface:
NamedParam(name string) stringmethod to support dialect-specific named parameter syntax@name, MySQL:?, SQLite::nameAST Formatting Fixes:
CollateExpr: Add missing Format method forCOLLATE <collation>supportInsertStmt: AddDefaultValues boolfield forINSERT INTO ... DEFAULT VALUESsyntaxA_Expr: Refactor named param detection to work regardless of Kind fieldSQLite Parser Improvements:
BoolExprBoolop field not being set for AND/OR expressionsjson_each(json_extract(...)))Test plan
TestFormattests pass (validates AST→SQL→fingerprint matches original)TestReplaytests pass (regenerated expected output for EXISTS tests)go test ./...tests pass🤖 Generated with Claude Code