Don't create observationCoroutineGrpcServerInterceptor bean when micrometer context-propagation isn't present on classpath #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answering a bit late on the question in #282
As it was mentioned in #283 the issue is caused by
context-propagationmissing on a classpath. The root-cause is a bit deeper. If observation is configured spring-grpc will create aObservationCoroutineContextServerInterceptorbean specifically for kotlin coroutine-based servers. Although this class doesn't require context-propagation directly, its dependencyKotlinObservationContextElementdoes. That's why the kotlin-sample server starts, but then it fails to process a request silently. Enabling the logs gives the root-cause:In RC1
spring-boot-starter-actuatorprovided context-propagation viaspring-boot-micrometer-tracing, but it's not the case anymore, see spring-projects/spring-boot#47785.Given all that, I propose a safe solution: don't create a
ObservationCoroutineContextServerInterceptorbean if context-propagation isn't available.