Explore Search Results #4960
Explore Search Results #4960
Conversation
There was a problem hiding this comment.
seems to have ended up in the wrong directory. should have been src/test/java, right?
| * Configuration whether to use ANN or ENN for the search. ANN is the default. | ||
| * | ||
| * @return the search type to use. | ||
| */ | ||
| VectorSearchOperation.SearchType searchType() default VectorSearchOperation.SearchType.ENN; |
There was a problem hiding this comment.
Documentation (default: ANN) contradicted by implementation (default: ENN).
MongoDB itself will use ANN by default (so the doc) is closer to what happens than the actual default value.
I think the MongoDB restrictions here do not allow much flexibility regarding defaulting of values. Like on the one hand ANN ist stated as default but requires numCandidates while the exact flag is labelled optional.
We could argue DEFAULT is a viable option here. Checking the numCandidates attribute, using ENN if no value present, ANN otherwise.
| * @author Mark Paluch | ||
| * @since 5.0 | ||
| */ | ||
| class VectorSearchExecution implements MongoQueryExecution { |
There was a problem hiding this comment.
curious if we can derive a more AOT friendly variant of this.
| if (query.isLimited()) { | ||
| limit = query.getLimit(); | ||
| } else { | ||
| limit = Math.max(1, numCandidates() != null ? numCandidates() / 20 : 1); |
There was a problem hiding this comment.
limit cannot exceed numCandidates and numCandidates should be at least 20x higher than limit but is deriving the limit the way it's done here valid?
There was a problem hiding this comment.
Probably doesn't make sense.
christophstrobl
force-pushed
the
issue/search
branch
from
511ac4a to
f5cab5d
Compare
fix invalid domain type reference and make sure to include required arguemtns
christophstrobl
force-pushed
the
issue/search
branch
from
f5cab5d to
72806aa
Compare
Original Pull Request: #4960
|
merged to 5.0.x |
Original Pull Request: #4960
Return
SearchResultfrom Repository Query methods.Depends on spring-projects/spring-data-commons#3285