-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add mathjax_config_file to load MathJax configuration from a file
#14025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mathjax_config_file to load MathJax configuration from a file
#14025
Conversation
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good based on a desk review (on mobile)!
I've left a few comments, but all minor.
A
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Is this really necessary? As I said in #13147, the reason why it doesn't work is MyST-Parser, not Sphinx. |
What a weird thing to ask for a feature PR. Almost no features are strictly necessary. They are added because they are useful. This feature is useful because it solves a problem (#13147) without affecting 3rd party extension compatibility. |
|
@randolf-scholz I think we can resolve these concerns in the extra docs I suggested in #14023 (comment), also noting that MyST does non-standard things with MathJax config. A |
|
@AA-Turner It's still unclear to me what exactly you want me to add in terms of documentation and where to put it. My latest commit adds a (blue) info box:
And also |
|
I added |
mathjax_config_file to load MathJax configuration from a file
|
Following @mgeier pointing out MyST's monkeypatching, I note that changing As such, I've adjusted this PR to instead introduce a new config option, A |

Fixes #14023
Note: git was telling me that these two files were modified, I'm not sure what's going on: