Skip to content

Conversation

@grantfitzsimmons
Copy link
Member

@grantfitzsimmons grantfitzsimmons commented Nov 19, 2025

Fixes #2078

Matches the behavior present in Specify 6. This prevents the crash that used to take place when adding fields via the geoCoordDetails and localityDetails relationship fields in Locality.

Note that the preview in the dialog will not currently show these values, but they will be displayed in the query results.
At the moment, this is not consistent.

#7570

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)

Testing instructions

image

Make sure to compare this behavior against main

  • Create or edit the Record Formatters app resource for the current collection
  • Add a Locality table format
  • Add fields from localityDetails and geoCoordDetails to the format directly
  • Verify that you can select all fields and relationships via these relationships
  • Set this format as the default
  • Edit the Locality record to include values in those fields
  • Use the Query Builder and add Locality (formatted) to the query with the added fields from before
  • Verify that the values are returned correctly and display in the query results and in exported CSV files

@grantfitzsimmons grantfitzsimmons marked this pull request as ready for review November 25, 2025 15:18
@grantfitzsimmons grantfitzsimmons added this to the 7.12.0 milestone Nov 25, 2025
@grantfitzsimmons grantfitzsimmons requested a review from a team November 25, 2025 15:21
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Create or edit the Record Formatters app resource for the current collection
  • Add a Locality table format
  • Add fields from localityDetails and geoCoordDetails to the format directly
  • Verify that you can select all fields and relationships via these relationships
  • Set this format as the default
  • Edit the Locality record to include values in those fields
  • Use the Query Builder and add Locality (formatted) to the query with the added fields from before
  • Verify that the values are returned correctly and display in the query results and in exported CSV files

Looks good, no longer getting an errror and results appear correctly.
image

image

@emenslin emenslin requested a review from a team November 25, 2025 16:29
Copy link
Collaborator

@bhumikaguptaa bhumikaguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to compare this behavior against main

  • Create or edit the Record Formatters app resource for the current collection
  • Add a Locality table format
  • Add fields from localityDetails and geoCoordDetails to the format directly
  • Verify that you can select all fields and relationships via these relationships
  • Set this format as the default
  • Edit the Locality record to include values in those fields
  • Use the Query Builder and add Locality (formatted) to the query with the added fields from before
  • Verify that the values are returned correctly and display in the query results and in exported CSV files

I was able to compare the behavior between main and the issue branch, it works as expected in issue branch.

@bhumikaguptaa bhumikaguptaa requested a review from a team November 26, 2025 21:37
@grantfitzsimmons grantfitzsimmons merged commit 04a6c88 into main Dec 5, 2025
14 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-2078 branch December 5, 2025 04:16
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Adding display format from Locality Detail to Locality's table format causes an error

6 participants