Skip to content

add darwin #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viphak wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add darwin #1

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40fdca0
darwin
viphak Sep 29, 2017
6b4ae24
clean
viphak Sep 29, 2017
aa37a82
implement based on netinet/tcp.h
viphak Oct 3, 2017
e5a1482
ren
viphak Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tcpkeepalive_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ func setCount(fd uintptr, n int) error {

func setInterval(fd uintptr, d time.Duration) error {
// # from https://golang.org/src/net/tcpsockopt_darwin.go
// d += (time.Second - time.Nanosecond)
// secs := int(d.Seconds())
// return os.NewSyscallError("setsockopt", syscall.SetsockoptInt(int(fd), syscall.IPPROTO_TCP, sysTCP_KEEPINTVL, secs))
// The kernel expects seconds so round to next highest second.
Copy link
Member

@sgotti sgotti Sep 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep this comment as it helps explaining the expected time unit.

d += (time.Second - time.Nanosecond)
secs := int(d.Seconds())
switch err := syscall.SetsockoptInt(int(fd), syscall.IPPROTO_TCP, sysTCP_KEEPINTVL, secs); err {
Expand Down