Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
976cded
Changed executable name, minimum reservoir thickness, doublet file na…
SHerrboldt Feb 19, 2025
f571c4f
Revert unwanted changes to TOUGH default parameter values
SHerrboldt Feb 19, 2025
811518d
Added TOUGH output files to ignore in gitignore
SHerrboldt Feb 19, 2025
8cb84dc
Update gitignore for TOUGH generated files (FOFT)
SHerrboldt Feb 20, 2025
3d1d29a
Added Doublet.out to .gitignore
SHerrboldt Mar 19, 2025
cc0d783
Extract production and injection well cells as variables in TOUGH and…
SHerrboldt Mar 19, 2025
8b7558a
Moved production and injection well cell variables to proper place
SHerrboldt Mar 19, 2025
251ba69
Raised RuntimeError instead of calling sys.exit()
SHerrboldt Mar 19, 2025
38763f8
Changed default value for Injection Well Cell ID and auditted to get …
SHerrboldt Mar 28, 2025
8df8f24
Merge branch 'main' into TOUGH-updates
SHerrboldt May 27, 2025
9f97920
Fixed some typos in MPFReservoir.py. Changed the default Delta Z grid…
SHerrboldt Jun 19, 2025
550ad3a
Merge remote-tracking branch 'origin/TOUGH-updates' into TOUGH-updates
SHerrboldt Jun 19, 2025
7213b5c
Fixed typo
SHerrboldt Jun 19, 2025
e45b836
Changed Delta Z grid to reservoirthickness/5 & converted calculated P…
SHerrboldt Jun 19, 2025
4457da6
Fixed parameter to show actual units in C/m
SHerrboldt Jun 19, 2025
548bb70
Fixed typo and added option to no include ambient temperature in Troc…
SHerrboldt Jun 19, 2025
0857355
Added Doublet.dat file
SHerrboldt Jun 19, 2025
389c27b
All changes from last commit
SHerrboldt Jun 19, 2025
33b8cf5
Added parameters for designating cell IDs (for horizontal well grid)
SHerrboldt Aug 7, 2025
8a8ea53
Minor changes to comments and .gitignore
SHerrboldt Oct 15, 2025
c8a7cf6
Changed for 1000m horizontal
SHerrboldt Oct 15, 2025
8d57778
Merge branch 'main' into TOUGH-updates
SHerrboldt Oct 15, 2025
77b41c5
temp ignore working files
softwareengineerprogrammer Nov 4, 2025
f43fea8
remove unused import
softwareengineerprogrammer Nov 4, 2025
d0cc2e6
restore Examples/
softwareengineerprogrammer Nov 4, 2025
d256964
Restore CLG Simulator/
softwareengineerprogrammer Nov 4, 2025
3706d0d
Merge branch 'main' into softwareengineerprogrammer_sherrboldt_tough-…
softwareengineerprogrammer Nov 4, 2025
5c11a99
revert unwanted change to max fracs in Reservoir.py
softwareengineerprogrammer Nov 4, 2025
924ccb6
Revert unwanted intersect temp change in Reservoir.py. Revert unwante…
softwareengineerprogrammer Nov 4, 2025
38df315
remove unwanted Examples/shr
softwareengineerprogrammer Nov 4, 2025
cea35b6
revert unwanted deletion of logging.conf
softwareengineerprogrammer Nov 4, 2025
1634427
revert backwards-incompatible change to Input Depth param name
softwareengineerprogrammer Nov 4, 2025
56cc816
regenerate schema
softwareengineerprogrammer Nov 4, 2025
1fa6207
remove unwanted new files in Examples/
softwareengineerprogrammer Nov 4, 2025
764d67a
Restore TestScript.bat
softwareengineerprogrammer Nov 4, 2025
036e2eb
revert copy editing (to keep diff cleaner)
softwareengineerprogrammer Nov 4, 2025
c39ce08
verify gradient_C_per_m in WellBores.py - add FIXME for overpressure …
softwareengineerprogrammer Nov 4, 2025
af0d1e4
revert unwanted copy editing to log message
softwareengineerprogrammer Nov 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,16 @@ SAVE
TABLE
rcc3.out
tough_debug_output/

# Temp
ai.md
regenerate-schemas.sh
requirements_2025-08-11.txt
src/geophires_x/CO2TAB
src/geophires_x/Doublet.dat
src/geophires_x/Doublet.out
src/geophires_x/FOFT_A3616.csv
src/geophires_x/FOFT_A36_2.csv
src/geophires_x/GOFT_A3616___021.csv
src/geophires_x/GOFT_A36_2___012.csv
src/geophires_x/INFILE
16 changes: 16 additions & 0 deletions src/geophires_x/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,20 @@ Examples\Test2.json
/temperature.txt
all_messages_conf.log

Doublet_default.dat

FOFT_A3Q23.csv
FOFT_A3Q28.csv
GENER
GOFT_A3Q23___012.csv
GOFT_A3Q28___021.csv
INCON
MESH
MESHA
MESHB
OUTPUT_ELEME.csv
SAVE
TABLE
tough2output.out

!sam_economics/Generic_400_MWe/*.json
4 changes: 2 additions & 2 deletions src/geophires_x/MPFReservoir.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ def __init__(self, model: Model):
Setting up includes giving it a name, a default value, The Unit Type (length, volume, temperature, etc)
and Unit Name of that value, sets it as required (or not), sets allowable range,
the error message if that range is exceeded, the ToolTip Text, and the name of teh class that created it.
This includes setting up temporary variables that will be available to all the class but noy read in by user,
This includes setting up temporary variables that will be available to all the class but not read in by user,
or used for Output
This also includes all Parameters that are calculated and then published using the Printouts function.
If you choose to subclass this master class, you can do so before or after you create your own parameters.
If you do, you can also choose to call this method from you class,
If you do, you can also choose to call this method from your class,
which will effectively add and set all these parameters to your class.
:param model: The container class of the application, giving access to everything else, including the logger
:type model: :class:`~geophires_x.Model.Model`
Expand Down
4 changes: 2 additions & 2 deletions src/geophires_x/Reservoir.py
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ def read_parameters(self, model: Model) -> None:
# This also deals with all the special cases that need to be taken care of
# after a value has been read in and checked.
# If you choose to subclass this master class, you can also choose to override this method (or not),
# and if you do, do it before or after you call you own version of this method. If you do, you can
# and if you do, do it before or after you call your own version of this method. If you do, you can
# also choose to call this method from you class, which can effectively modify all these
# superclass parameters in your class.

Expand Down Expand Up @@ -729,7 +729,7 @@ def Calculate(self, model: Model) -> None:

# temperatureindex = max(loc for loc, val in enumerate(self.depth.value > totaldepth) if val is True)
self.Trock.value = intersecttemperature[temperatureindex] + self.gradient.value[temperatureindex] * \
(self.depth.value - totaldepth[temperatureindex])
(self.depth.value - totaldepth[temperatureindex])

# calculate average geothermal gradient
if self.numseg.value == 1:
Expand Down
2 changes: 1 addition & 1 deletion src/geophires_x/SBTReservoir.py
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def Calculate_Coaxial(self, model):
# SBT v2 for co-axial heat exchanger with high-temperature capability
# last update: January 14th, 2024

# 1. Input
# 1. Inputs
# Generally, the user should only make changes to this section

fluid = 1 # Heat transfer fluid selection: 1 = H2O; 2 = CO2
Expand Down
2 changes: 1 addition & 1 deletion src/geophires_x/SurfacePlantAGS.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def __init__(self, model: Model):
ErrMessage="assume default Dead-state pressure (1e5 Pa)"
)

# Input data for electricity generation with CO2
# Inputs data for electricity generation with CO2
self.Turbine_isentropic_efficiency = self.ParameterDict[
self.Turbine_isentropic_efficiency.Name] = floatParameter(
"Isentropic Efficiency for CO2 Turbine",
Expand Down
2 changes: 1 addition & 1 deletion src/geophires_x/SurfacePlantAbsorptionChiller.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(self, model: Model):
self.MyClass = self.__class__.__name__
self.MyPath = __file__

# Input parameters absorption chiller
# Inputs parameters absorption chiller
self.absorption_chiller_cop = self.ParameterDict[self.absorption_chiller_cop.Name] = floatParameter(
"Absorption Chiller COP",
value=0.7,
Expand Down
Loading