Skip to content

[iOS] Remove dropped native handlers #3819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 17, 2025
Merged

[iOS] Remove dropped native handlers #3819

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b8d99d
Remove dropped handlers
m-bert Nov 13, 2025
56e79a6
Override prepareForRecycle
m-bert Nov 14, 2025
695011d
Merge branch 'next' into @mbert/fix-native-attach
m-bert Nov 14, 2025
767a938
Reset remaining fields
m-bert Nov 17, 2025
4e99b77
Extract assignments to function
m-bert Nov 17, 2025
cfd61e6
Merge branch 'next' into @mbert/fix-native-attach
m-bert Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerDetector.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ + (BOOL)shouldBeRecycled
- (instancetype)initWithFrame:(CGRect)frame
{
if (self = [super initWithFrame:frame]) {
static const auto defaultProps = std::make_shared<const RNGestureHandlerDetectorProps>();
_props = defaultProps;
_moduleId = -1;
_nativeHandlers = [NSMutableSet set];
_attachedHandlers = [NSMutableSet set];
[self setDefaultProps];
}

return self;
Expand Down Expand Up @@ -72,6 +68,15 @@ - (void)willMoveToWindow:(RNGHWindow *)newWindow
}
}

- (void)setDefaultProps
{
static const auto defaultProps = std::make_shared<const RNGestureHandlerDetectorProps>();
_props = defaultProps;
_moduleId = -1;
_nativeHandlers = [NSMutableSet set];
_attachedHandlers = [NSMutableSet set];
}

- (void)dispatchStateChangeEvent:(RNGestureHandlerDetectorEventEmitter::OnGestureHandlerStateChange)event
{
if (_eventEmitter != nullptr) {
Expand Down Expand Up @@ -127,6 +132,13 @@ - (BOOL)shouldAttachGestureToSubview:(NSNumber *)handlerTag
return [[[handlerManager registry] handlerWithTag:handlerTag] wantsToAttachDirectlyToView];
}

- (void)prepareForRecycle
{
[super prepareForRecycle];

[self setDefaultProps];
}

- (void)didAddSubview:(RNGHUIView *)view
{
[super didAddSubview:view];
Expand Down
Loading