Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { State } from '../../State';
import NodeManager from '../../web/tools/NodeManager';
import { GestureStateManagerType } from './gestureStateManager';

Expand All @@ -11,7 +12,15 @@ export const GestureStateManager = {
},

activate: () => {
NodeManager.getHandler(handlerTag).activate(true);
const handler = NodeManager.getHandler(handlerTag);

// Force going from UNDETERMINED to ACTIVE through BEGAN to preserve
// the correct state transition flow.
if (handler.state === State.UNDETERMINED) {
handler.begin();
}

handler.activate(true);
},

fail: () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ export default class FlingGestureHandler extends GestureHandler {

super.onPointerDown(event);
this.newPointerAction();

this.tryToSendTouchEvent(event);
}

protected override onPointerAdd(event: AdaptedEvent): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ export default abstract class GestureHandler implements IGestureHandler {
GestureHandlerOrchestrator.instance.cancelMouseAndPenGestures(this);
}

// TODO: Bring back touch events along with introducing `handleDown` method that will handle handler specific stuff
this.tryToSendTouchEvent(event);
}
// Adding another pointer to existing ones
protected onPointerAdd(event: AdaptedEvent): void {
Expand Down Expand Up @@ -347,9 +347,9 @@ export default abstract class GestureHandler implements IGestureHandler {
protected onPointerEnter(event: AdaptedEvent): void {
this.tryToSendTouchEvent(event);
}
protected onPointerCancel(event: AdaptedEvent): void {
this.tryToSendTouchEvent(event);

protected onPointerCancel(_event: AdaptedEvent): void {
// No need to send a cancel touch event explicitly here. `cancel` will
// handle cancelling all tracked touches if the handler expects pointer data.
this.cancel();
this.reset();
}
Expand All @@ -370,11 +370,10 @@ export default abstract class GestureHandler implements IGestureHandler {
return;
}

this.tryToSendTouchEvent(event);
if (this.active) {
this.sendEvent(this.state, this.state);
}

this.tryToSendTouchEvent(event);
}

protected tryToSendTouchEvent(event: AdaptedEvent): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ export default class LongPressGestureHandler extends GestureHandler {

this.tryBegin();
this.tryActivate();

this.tryToSendTouchEvent(event);
}
protected override onPointerAdd(event: AdaptedEvent): void {
super.onPointerAdd(event);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ export default class ManualGestureHandler extends GestureHandler {
this.tracker.addToTracker(event);
super.onPointerDown(event);
this.begin();

this.tryToSendTouchEvent(event);
}

protected override onPointerAdd(event: AdaptedEvent): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ export default class NativeViewGestureHandler extends GestureHandler {
this.tracker.addToTracker(event);
super.onPointerDown(event);
this.newPointerAction();

this.tryToSendTouchEvent(event);
}

protected override onPointerAdd(event: AdaptedEvent): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,6 @@ export default class PanGestureHandler extends GestureHandler {

this.tryBegin(event);
this.checkBegan();

this.tryToSendTouchEvent(event);
}

protected override onPointerAdd(event: AdaptedEvent): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ export default class PinchGestureHandler extends GestureHandler {
protected override onPointerDown(event: AdaptedEvent): void {
this.tracker.addToTracker(event);
super.onPointerDown(event);

this.tryToSendTouchEvent(event);
}

protected override onPointerAdd(event: AdaptedEvent): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ export default class RotationGestureHandler extends GestureHandler {
protected override onPointerDown(event: AdaptedEvent): void {
this.tracker.addToTracker(event);
super.onPointerDown(event);

this.tryToSendTouchEvent(event);
}

protected override onPointerAdd(event: AdaptedEvent): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ export default class TapGestureHandler extends GestureHandler {
this.lastY = event.y;

this.updateState(event);

this.tryToSendTouchEvent(event);
}

protected override onPointerAdd(event: AdaptedEvent): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ export default class GestureHandlerOrchestrator {

private scheduleFinishedHandlersCleanup(): void {
if (this.handlingChangeSemaphore === 0) {
this.cleanupFinishedHandlers();
queueMicrotask(() => {
this.cleanupFinishedHandlers();
});
}
}

Expand Down
Loading