-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add support for codeblock on iOS #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for codeblock on iOS #253
Conversation
szydlovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there!
Co-authored-by: Mikołaj Szydłowski <9szydlowski9@gmail.com>
szydlovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work! Looks and functions really well 🔥
14c8cb1 to
978fbde
Compare
|
Functionally it works well, however, I've noticed one issue. When you press backspace at beginning of the line it should remove style rather than go to previous line. I believe it should work the same as it works for block quote currently Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-11-24.at.14.18.21.mov |
|
@exploIF we decided with @szydlovsky that when you press backspace it will go back to the previous line, it is expected behavior. When you look how for example Slack works with |
|
Also, this way backspacing inside of a codeblock lets you just move stuff inside it instead of separating it into two codeblocks because style got removed for the line. |
|
@kacperzolkiewski @szydlovsky So, this means that we also have to adjust that on Android, right now it's inconsistent |
Summary
Add support for
codeblock.Test Plan
Run Example app and play with
codeblockScreenshots
Compatibility