feat: add ability to get html value imperatively #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Nov 7, 2025
| import com.swmansion.enriched.utils.EnrichedParser | ||
|
|
||
| @ReactModule(name = EnrichedTextInputModule.NAME) | ||
| class EnrichedTextInputModule(val reactContext: ReactApplicationContext) : |
Member
There was a problem hiding this comment.
I don't like the fact that this PR introduces a native module. Why exactly is that needed?
Contributor
Author
There was a problem hiding this comment.
This is necessary because native commands do not allow you to return any values. If you have any other ideas on how the second option in this list can be implemented without a module, I would be happy to change the current implementation 🙂
| - (nonnull NSString *)getHTMLValue:(NSInteger)inputTag { | ||
| __block NSString *value = @""; | ||
|
|
||
| dispatch_sync(dispatch_get_main_queue(), ^{ |
Member
There was a problem hiding this comment.
I don't like the fact that we need dispatch_sync here. It blocks the current thread.
Contributor
Author
There was a problem hiding this comment.
Okay, I have a compromise approach. We can keep this method and add another one
- The new method will work like this: On the main or background thread, we can copy the editable/attributed text value and then parse it on the background thread. Since I think the performant work is done in the parser
- We can add a BOOOOLD note that the sync method might block the UI thread, and it's not recommended for usage or use it with caution.
It would be nice to hear your point of view 🙂
Co-authored-by: Tomasz Zawadzki <tomekzawadzki98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to get the HTML value from the reference of the EnrichedTextInput itself. This way, we don't need to parse the text with every change, which improves speed.
How to test?
Videos
iOS:
Screen.Recording.2025-11-07.at.13.26.06.mov
Android:
Screen.Recording.2025-11-07.at.13.27.06.mp4