Skip to content

Conversation

@xeruf
Copy link
Member

@xeruf xeruf commented Oct 7, 2019

The Player object right now is a big mess, it handles color, name, listeners and reporting invalid player moves. I want to separate these concerns with this PR.

@xeruf xeruf changed the title Rework Player Rework/Player Oct 7, 2019
@anarchuser
Copy link
Contributor

Do you think it makes sense to update this PR?
the plugin2020 shouldn't matter anymore anyways

@xeruf
Copy link
Member Author

xeruf commented Jul 13, 2020

Well the general premise should be implemented - having separate player classes for network client vs an entity that plays. But I guess starting from scratch would be faster. Until then we can keep this as reference.

@anarchuser
Copy link
Contributor

I'm looking into what can be done right now.

As I see it, we need to move the Team/PlayerColor stuff into the game plugin (since the way that teams / colours are defined differs between the games) and only leave the player representing the client in the sdk

@xeruf
Copy link
Member Author

xeruf commented Jul 13, 2020

Well, for all games so far the color was an identifying feature of the player, I think this is the first one where it is different - so the perfect time to rethink the architecture ;)

@anarchuser
Copy link
Contributor

yes, as I already mentioned.
I'll create a new PR where I just rework the colors; afterwards I'll look into what's needed to rework the player

@xeruf xeruf force-pushed the master branch 2 times, most recently from e4240d9 to 040b96b Compare September 9, 2020 21:20
@xeruf xeruf added the action:rework A big redesign of a component label Nov 13, 2020
@xeruf xeruf added this to the long-term milestone Feb 11, 2021
@xeruf xeruf changed the title Rework/Player Separate concerns of Player object May 14, 2021
@xeruf xeruf changed the base branch from master to main May 14, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action:rework A big redesign of a component component:gaming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants