Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

Conversation

@ccorcos
Copy link

@ccorcos ccorcos commented Oct 12, 2022

Experimenting with building typescript types from JSDoc comments.

socketsupply/socket#14

There are a variety of little problems left to solve though...

  • TypedArray isn't a global type currently so that needs to get injected.
  • err is not a type. Could just change these to Error
  • Several places with a non-optional argument followed by an optional argument: options?: any | undefined, callback: Function
  • Some types need to be imported from elsewhere for the types to work, like fs.ReadStream

All in all, this seems pretty achievable, but I'm afraid this is an 80-20 effort so far and much pain and suffering lies again. haha

@trevnorris trevnorris requested a review from jwerle January 17, 2023 23:02
@trevnorris
Copy link

trevnorris commented Jan 17, 2023

@jwerle Is this change still applicable? I'm trying to reassess everything now that the ipc-cleanup branch has landed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants