Skip to content

NO-SNOW: Stop CRL cache background task when closing conn #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 12, 2025
Merged

NO-SNOW: Stop CRL cache background task when closing conn #2633

merged 5 commits into from
Nov 12, 2025

Conversation

@sfc-gh-turbaszek
Copy link
Contributor

@sfc-gh-turbaszek sfc-gh-turbaszek commented Nov 6, 2025

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-turbaszek sfc-gh-turbaszek requested review from a team as code owners November 6, 2025 09:30
sfc-gh-fpawlowski
sfc-gh-fpawlowski reviewed Nov 6, 2025
View reviewed changes
sfc-gh-fpawlowski
sfc-gh-fpawlowski approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 nits.

sfc-gh-fpawlowski
sfc-gh-fpawlowski reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great, there are only some tests failing now

@sfc-gh-fpawlowski sfc-gh-fpawlowski self-requested a review November 6, 2025 13:42
@sfc-gh-turbaszek sfc-gh-turbaszek added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Nov 6, 2025
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 9c132c2 into main Nov 12, 2025
102 of 111 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the turbaszek-crl-fix branch November 12, 2025 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-fpawlowski sfc-gh-fpawlowski sfc-gh-fpawlowski approved these changes

Assignees

No one assigned

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-turbaszek @sfc-gh-fpawlowski