Skip to content

fix: naming SLURM logs, SLURM logs not just "log files" #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: naming SLURM logs, SLURM logs not just "log files" #372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af4290b
fix: speaking of SLURM logs to differentiate between SLURM and Snakem…
cmeesters Nov 6, 2025
ef2fb1a
Update snakemake_executor_plugin_slurm/__init__.py
cmeesters Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions snakemake_executor_plugin_slurm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def clean_old_logs(self) -> None:
return
cutoff_secs = age_cutoff * 86400
current_time = time.time()
self.logger.info(f"Cleaning up log files older than {age_cutoff} day(s).")
self.logger.info(f"Cleaning up SLURM log files older than {age_cutoff} day(s).")

for path in self.slurm_logdir.rglob("*.log"):
if path.is_file():
Expand Down Expand Up @@ -525,15 +525,15 @@ async def check_active_jobs(
active_jobs_seen_by_sacct.remove(j.external_jobid)
if not self.workflow.executor_settings.keep_successful_logs:
self.logger.debug(
"removing log for successful job "
"removing SLURM log for successful job "
f"with SLURM ID '{j.external_jobid}'"
)
try:
if j.aux["slurm_logfile"].exists():
j.aux["slurm_logfile"].unlink()
except (OSError, FileNotFoundError) as e:
self.logger.warning(
"Could not remove log file"
"Could not remove SLURM log file"
f" {j.aux['slurm_logfile']}: {e}"
)
elif status == "PREEMPTED" and not self._preemption_warning:
Expand Down