Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-moles-grab.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/core": patch
---

omit undefined values in cbor deserialization
19 changes: 19 additions & 0 deletions packages/core/src/submodules/cbor/CborCodec.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,23 @@ describe(CborShapeSerializer.name, () => {
}
});
});

describe("deserialization", () => {
it("should not create undefined values", async () => {
const struct = [3, "ns", "Struct", 0, ["sessionId", "tokenId"], [0, 0]] satisfies StaticStructureSchema;
const deserializer = codec.createDeserializer();

const data = cbor.serialize({
sessionId: "abcd",
});

const deserialized = deserializer.read(struct, data);

expect(deserialized).toEqual({
sessionId: "abcd",
});

expect("tokenId" in deserialized).toEqual(false);
});
});
});
5 changes: 4 additions & 1 deletion packages/core/src/submodules/cbor/CborCodec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ export class CborShapeDeserializer extends SerdeContext implements ShapeDeserial
}
} else if (ns.isStructSchema()) {
for (const [key, memberSchema] of ns.structIterator()) {
newObject[key] = this.readValue(memberSchema, value[key]);
const v = this.readValue(memberSchema, value[key]);
if (v != null) {
newObject[key] = v;
}
}
}
return newObject;
Expand Down