Skip to content

slog 2.8 deprecation warnings fix #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

slog 2.8 deprecation warnings fix #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e9b225
Fix deprecation warning after slog 2.8 came out
jendakol Oct 6, 2025
af65540
Fix clippy warning
jendakol Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ use arc_swap::ArcSwap;

use std::result;

pub use slog::{slog_crit, slog_debug, slog_error, slog_info, slog_trace, slog_warn};
pub use slog::{
Copy link
Contributor

@dpc dpc Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mark these names as deprecated too now?

Copy link
Author

@jendakol jendakol Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the least-effort path 😅 But it crossed my mind for a second, too. The decision is up to you 😉

crit as slog_crit, debug as slog_debug, error as slog_error, info as slog_info,
trace as slog_trace, warn as slog_warn,
};

/// Log a critical level message using current scope logger
#[macro_export]
Expand Down Expand Up @@ -245,6 +248,6 @@ where F : FnOnce(&Logger) -> R {
pub fn scope<SF, R>(logger: &slog::Logger, f: SF) -> R
where SF: FnOnce() -> R
{
let _guard = ScopeGuard::new(&logger);
let _guard = ScopeGuard::new(logger);
f()
}