Skip to content

Conversation

@codomposer
Copy link
Contributor

@codomposer codomposer commented Nov 11, 2025

Summary

Closes #1729

Testing

  • Run all TableBlock tests
    python -m pytest tests/slack_sdk/models/test_blocks.py::TableBlockTests -v

  • Run all block tests to ensure no regressions
    python -m pytest tests/slack_sdk/models/test_blocks.py -v

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Contribution by Gittensor, learn more at https://gittensor.io/

@codomposer codomposer changed the title add tablblock to blocks add tableblock to blocks Nov 11, 2025
@codomposer
Copy link
Contributor Author

@hello-ashleyintech
can you please check this pull request?

@hello-ashleyintech
Copy link
Contributor

@codomposer Thanks for your contribution! taking a look now!

@hello-ashleyintech hello-ashleyintech added the enhancement M-T: A feature request for new functionality label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.90%. Comparing base (c04e899) to head (2d4a18e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
+ Coverage   83.86%   83.90%   +0.03%     
==========================================
  Files         115      115              
  Lines       13049    13080      +31     
==========================================
+ Hits        10944    10975      +31     
  Misses       2105     2105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codomposer
Copy link
Contributor Author

if everything is fine, can you merge this pr?

@zimeg zimeg changed the title add tableblock to blocks feat: add table block Nov 11, 2025
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codomposer Thanks for sending this in! The code also LGTM but I'm hesitant to merge this right now with a possible API issue.

Can you let me know if you're finding something else? I believe server side changes are ongoing so hoping we can merge this soon! 🤖

@codomposer codomposer requested a review from zimeg November 11, 2025 18:09
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codomposer Thanks once more for these changes and conversation above! 👾

I'm finding a possible issue around raw_text in a recent commit, but believe the backend changes have since resolved. I'll explore similar changes in slackapi/node-slack-sdk#2426 but please let me know if I can help or review again!

@codomposer codomposer requested a review from a team as a code owner November 19, 2025 21:12
@codomposer codomposer requested a review from zimeg November 19, 2025 21:13
@zimeg zimeg mentioned this pull request Nov 19, 2025
15 tasks
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codomposer Thank you again for bringing improvements to reference alongside these changes! I made a few update after final testing, but think we can merge this:

  • ee24a66: The max length noted in the Node SDK was in error - for now a raw_text limit isn't in reference so let's omit it here.
  • 2d4a18e: These tests are comprehensive but might not bring the confidence we hope for - I noticed these mocked incorrect responses from the API which might be outside the scope of this block addition for now.

You're super awesome for keeping up with all of these changes as we were debugging some things on the backend too. It's much appreciated! Let's merge this for next release! 🚢 💨

@zimeg zimeg added this to the 3.39.0 milestone Nov 19, 2025
@zimeg zimeg merged commit 9fd33fe into slackapi:main Nov 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed enhancement M-T: A feature request for new functionality semver:minor Version: 3x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TableBlock to the slack_sdk.model.blocks

3 participants