You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes SCSS and thus the build step introducing major DX improvements, it's a bit more verbose, but our design system really doesn't change, if at all. And it's still managble. Tailwind does the same with their themes, just a giant list of theme variables, no build step either. I think this is the right approach.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@Hugos68 overall I like the idea. It does simplify things for values that haven't changed since introduction.
The only oddity I've seen in the Theme menu/pages don't show the surface color for each theme. Not sure the cause, but these are definitely working in the production.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes SCSS and thus the build step introducing major DX improvements, it's a bit more verbose, but our design system really doesn't change, if at all. And it's still managble. Tailwind does the same with their themes, just a giant list of theme variables, no build step either. I think this is the right approach.