Merge pull request #836 from sir-gon/develop

[BUGFIX] SonarQube: Prefer `Number.parseInt` over `parseInt`.

Author: sir-gon

src/hackerrank/implementation/countApplesAndOranges.ts

@@ -25,9 +25,7 @@ function countApplesAndOranges(
     }
   }
 
-  const result: number[] = [];
-  result.push(cApples);
-  result.push(cOranges);
+  const result: number[] = [cApples, cOranges];
 
   return result.join('\n');
 }

src/hackerrank/implementation/countingValleys.ts

@@ -11,7 +11,7 @@ function countingValleys(steps: number, path: string): number {
 
   console.debug(stepList);
 
-  stepList.forEach((step) => {
+  for (const step of stepList) {
     if (step === 'D') {
       if (altitude === 0) {
         valleys += 1;
@@ -21,7 +21,7 @@ function countingValleys(steps: number, path: string): number {
     if (step === 'U') {
       altitude += 1;
     }
-  });
+  }
 
   return valleys;
 }

src/hackerrank/implementation/repeatedString.ts

@@ -9,11 +9,11 @@ function countAs(word: string): number {
 
   const chars = word.split('');
 
-  chars.forEach((char) => {
+  for (const char of chars) {
     if (char === 'a') {
       result += 1;
     }
-  });
+  }
 
   return result;
 }

src/hackerrank/implementation/sockMerchant.ts

@@ -11,9 +11,9 @@ function sockMerchant(n: number, ar: number[]): number {
 
   const matches: Matches = {};
 
-  ar.forEach((v) => {
+  for (const v of ar) {
     matches[v] = matches?.[v] ? matches[v] + 1 : 1;
-  });
+  }
 
   console.debug(matches);
 

src/hackerrank/interview_preparation_kit/arrays/2d_array.test.ts

@@ -8,15 +8,15 @@ describe('arrays: 2d Array hourglassSum', () => {
   it('hourglassSum Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = hourglassSum(test.input);
 
       console.debug(
         `gethourGlass(${test.input.toString()}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });

src/hackerrank/interview_preparation_kit/arrays/2d_array.ts

@@ -7,18 +7,19 @@ function gethourGlass(
   positionX: number,
   positionY: number
 ): number[] {
-  const result: number[] = [];
+  const result: number[] = [
+    // top
+    arr[positionX - 1][positionY - 1],
+    arr[positionX - 1][positionY],
+    arr[positionX - 1][positionY + 1],
+    // middle
+    arr[positionX][positionY],
+    // bottom
+    arr[positionX + 1][positionY - 1],
+    arr[positionX + 1][positionY],
+    arr[positionX + 1][positionY + 1]
+  ];
 
-  // top
-  result.push(arr[positionX - 1][positionY - 1]);
-  result.push(arr[positionX - 1][positionY]);
-  result.push(arr[positionX - 1][positionY + 1]);
-  // middle
-  result.push(arr[positionX][positionY]);
-  // bottom
-  result.push(arr[positionX + 1][positionY - 1]);
-  result.push(arr[positionX + 1][positionY]);
-  result.push(arr[positionX + 1][positionY + 1]);
   return result;
 }
 

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.test.ts

@@ -9,15 +9,15 @@ describe('arrays: crush (bruteforce) small cases', () => {
   it('arrayManipulation Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = arrayManipulation(test.n, test.queries);
 
       console.debug(
         `arrayManipulation(${test.n}, ${test.queries.toString()}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.ts

@@ -11,19 +11,19 @@ function arrayManipulation(n: number, queries: number[][]): number {
   const result: number[] = new Array<number>(LENGTH).fill(SURROGATE_VALUE);
   let maximum = 0;
 
-  queries.forEach((query) => {
+  for (const query of queries) {
     const [aStart, bEnd, kValue] = query;
     console.debug(`start -> ${result.toString()}`);
 
     for (let i = aStart; i <= bEnd; i++) {
       result[i] += kValue;
       console.debug(`result -> ${result.toString()}`);
     }
-  });
+  }
 
-  result.forEach((value) => {
+  for (const value of result) {
     maximum = Math.max(value, maximum);
-  });
+  }
 
   return maximum;
 }

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.test.ts

@@ -9,15 +9,15 @@ describe('arrays: crush (optimized)', () => {
   it('arrayManipulation Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = arrayManipulation(test.n, test.queries);
 
       console.debug(
         `arrayManipulation(${test.n}, ${test.queries.toString()}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.ts

@@ -11,19 +11,19 @@ function arrayManipulation(n: number, queries: number[][]): number {
   const result = new Array(LENGTH).fill(INITIAL_VALUE);
   let maximum = 0;
 
-  queries.forEach((query) => {
+  for (const query of queries) {
     const [aStart, bEnd, kValue] = query;
 
     result[aStart] += kValue;
     result[bEnd + 1] -= kValue;
-  });
+  }
 
   let accumSum = 0;
 
-  result.forEach((value) => {
+  for (const value of result) {
     accumSum += value;
     maximum = Math.max(maximum, accumSum);
-  });
+  }
 
   return maximum;
 }