[BUGFIX] SonarQube: Do not call Array#push() multiple times.

Multiple consecutive calls to methods that accept multiple arguments should be combined typescript:S7778

Author: Gonzalo Diaz

src/hackerrank/implementation/countApplesAndOranges.ts

@@ -25,9 +25,7 @@ function countApplesAndOranges(
     }
   }
 
-  const result: number[] = [];
-  result.push(cApples);
-  result.push(cOranges);
+  const result: number[] = [cApples, cOranges];
 
   return result.join('\n');
 }

src/hackerrank/interview_preparation_kit/arrays/2d_array.ts

@@ -7,18 +7,19 @@ function gethourGlass(
   positionX: number,
   positionY: number
 ): number[] {
-  const result: number[] = [];
+  const result: number[] = [
+    // top
+    arr[positionX - 1][positionY - 1],
+    arr[positionX - 1][positionY],
+    arr[positionX - 1][positionY + 1],
+    // middle
+    arr[positionX][positionY],
+    // bottom
+    arr[positionX + 1][positionY - 1],
+    arr[positionX + 1][positionY],
+    arr[positionX + 1][positionY + 1]
+  ];
 
-  // top
-  result.push(arr[positionX - 1][positionY - 1]);
-  result.push(arr[positionX - 1][positionY]);
-  result.push(arr[positionX - 1][positionY + 1]);
-  // middle
-  result.push(arr[positionX][positionY]);
-  // bottom
-  result.push(arr[positionX + 1][positionY - 1]);
-  result.push(arr[positionX + 1][positionY]);
-  result.push(arr[positionX + 1][positionY + 1]);
   return result;
 }
 

src/hackerrank/warmup/plusMinus.ts

@@ -17,11 +17,11 @@ function plusMinus(arr: number[]): string {
     }
   }
 
-  const result: string[] = [];
-
-  result.push((positives / arr.length).toFixed(6));
-  result.push((negatives / arr.length).toFixed(6));
-  result.push((zeros / arr.length).toFixed(6));
+  const result: string[] = [
+    (positives / arr.length).toFixed(6),
+    (negatives / arr.length).toFixed(6),
+    (zeros / arr.length).toFixed(6)
+  ];
 
   return result.join(`\n`);
 }