[BUGFIX] SonarQube: Use for…of instead of .forEach(…).

Use "for...of" loops instead of "forEach" method calls javascript:S7728

Author: Gonzalo Diaz

src/hackerrank/implementation/countingValleys.js

@@ -11,7 +11,7 @@ function countingValleys(steps, path) {
 
   console.debug(stepList);
 
-  stepList.forEach((step) => {
+  for (const step of stepList) {
     if (step === 'D') {
       if (altitude === 0) {
         valleys += 1;
@@ -21,7 +21,7 @@ function countingValleys(steps, path) {
     if (step === 'U') {
       altitude += 1;
     }
-  });
+  }
 
   return valleys;
 }

src/hackerrank/implementation/repeatedString.js

@@ -9,11 +9,11 @@ function countAs(word) {
 
   const chars = word.split('');
 
-  chars.forEach((char) => {
+  for (const char of chars) {
     if (char === 'a') {
       result += 1;
     }
-  });
+  }
 
   return result;
 }

src/hackerrank/implementation/sockMerchant.js

@@ -9,9 +9,9 @@ function sockMerchant(n, ar) {
 
   const matches = {};
 
-  ar.forEach((v) => {
+  for (const v of ar) {
     matches[v] = matches?.[v] ? matches[v] + 1 : 1;
-  });
+  }
 
   console.debug(matches);
 

src/hackerrank/interview_preparation_kit/arrays/2d_array.test.js

@@ -8,15 +8,15 @@ describe('arrays: 2d Array hourglassSum', () => {
   it('hourglassSum Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = hourglassSum(test.input);
 
       console.debug(
         `gethourGlass(${test.input.toString()}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.js

@@ -11,19 +11,19 @@ function arrayManipulation(n, queries) {
   const result = Array(LENGTH).fill(SURROGATE_VALUE);
   let maximum = 0;
 
-  queries.forEach((query) => {
+  for (const query of queries) {
     const [aStart, bEnd, kValue] = query;
     console.debug(`start -> ${result}`);
 
     for (let i = aStart; i <= bEnd; i++) {
       result[i] += kValue;
       console.debug(`result -> ${result}`);
     }
-  });
+  }
 
-  result.forEach((value) => {
+  for (const value of result) {
     maximum = Math.max(value, maximum);
-  });
+  }
 
   return maximum;
 }

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.test.js

@@ -9,15 +9,15 @@ describe('arrays: crush (bruteforce) small cases', () => {
   it('arrayManipulation Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = arrayManipulation(test.n, test.queries);
 
       console.debug(
         `arrayManipulation(${test.n}, ${test.queries}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.js

@@ -11,19 +11,19 @@ function arrayManipulation(n, queries) {
   const result = Array(LENGTH).fill(INITIAL_VALUE);
   let maximum = 0;
 
-  queries.forEach((query) => {
+  for (const query of queries) {
     const [aStart, bEnd, kValue] = query;
 
     result[aStart] += kValue;
     result[bEnd + 1] -= kValue;
-  });
+  }
 
   let accumSum = 0;
 
-  result.forEach((value) => {
+  for (const value of result) {
     accumSum += value;
     maximum = Math.max(maximum, accumSum);
-  });
+  }
 
   return maximum;
 }

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.test.js

@@ -9,15 +9,15 @@ describe('arrays: crush (optimized)', () => {
   it('arrayManipulation Test Cases', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = arrayManipulation(test.n, test.queries);
 
       console.debug(
         `arrayManipulation(${test.n}, ${test.queries}) solution found: ${answer}`
       );
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });

src/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.test.js

@@ -9,13 +9,13 @@ describe('ctci_array_left_rotation', () => {
   it('rotLeft Test cases', () => {
     expect.assertions(9);
 
-    ROT_LEFT_TEST_CASES.forEach((test) => {
+    for (const test of ROT_LEFT_TEST_CASES) {
       const answer = rotLeft(test.input, test.d_rotations);
 
       console.debug(`rotLeft(${test.numbers}) solution found: ${answer}`);
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(ROT_LEFT_TEST_CASES).toHaveLength(8);
   });

src/hackerrank/interview_preparation_kit/arrays/minimum_swaps_2.test.js

@@ -9,13 +9,13 @@ describe('minimum swaps 2', () => {
   it('minimumSwaps', () => {
     expect.assertions(4);
 
-    TEST_CASES.forEach((test) => {
+    for (const test of TEST_CASES) {
       const answer = minimumSwaps(test.input);
 
       console.debug(`minimumSwaps(${test.input}) solution found: ${answer}`);
 
       expect(answer).toStrictEqual(test.expected);
-    });
+    }
 
     expect(TEST_CASES).toHaveLength(3);
   });