Skip to content

Commit 054a39f

Browse files
author
Gonzalo Diaz
committed
[BUGFIX] SonarQube: Prefer Number.parseInt over parseInt.
Number static methods and properties should be preferred over global equivalents javascript:S7773
1 parent de0b4a7 commit 054a39f

File tree

13 files changed

+18
-17
lines changed

13 files changed

+18
-17
lines changed

src/hackerrank/interview_preparation_kit/miscellaneous/flipping-bits.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function flippingBits(n) {
1919
}
2020
});
2121

22-
return parseInt(resultBinStr, __BINARY_BASE__);
22+
return Number.parseInt(resultBinStr, __BINARY_BASE__);
2323
}
2424

2525
export default { flippingBits };

src/hackerrank/interview_preparation_kit/recursion_and_backtracking/recursive_digit_sum.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ const RADIX = 10;
66

77
function superDigitCompute(n) {
88
if (n.length === 1) {
9-
return parseInt(n, RADIX);
9+
return Number.parseInt(n, RADIX);
1010
}
1111

1212
let partial = 0;
1313
for (const digit of n) {
14-
partial += parseInt(digit, RADIX);
14+
partial += Number.parseInt(digit, RADIX);
1515
}
1616

1717
return superDigitCompute(`${partial}`);

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ function whatFlavorsCompute(cost, money) {
77
const RADIX = 10;
88

99
for (const [key, price] of Object.entries(cost)) {
10-
const i = parseInt(key, RADIX);
10+
const i = Number.parseInt(key, RADIX);
1111
const diff = money - price;
1212

1313
if (Number.isInteger(cache?.[diff])) {

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor_bruteforce.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function whatFlavorsBruteforceCompute(cost, money) {
66
const RADIX = 10;
77

88
for (const key of Object.keys(cost)) {
9-
const i = parseInt(key, RADIX);
9+
const i = Number.parseInt(key, RADIX);
1010
const x = cost[i];
1111

1212
const budget = money - x;

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor_optimized.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function whatFlavorsCompute(cost, money) {
1414
}
1515

1616
for (const key of Object.keys(cost)) {
17-
const i = parseInt(key, RADIX);
17+
const i = Number.parseInt(key, RADIX);
1818

1919
const v1 = cost[i];
2020
const v2 = money - v1;
@@ -34,7 +34,7 @@ function whatFlavorsCompute(cost, money) {
3434

3535
const result = new Set();
3636
for (const key of Object.keys(cost)) {
37-
const x = parseInt(key, RADIX);
37+
const x = Number.parseInt(key, RADIX);
3838

3939
if (cost[x] === ans1 || cost[x] === ans2) {
4040
result.add(x + 1);

src/hackerrank/interview_preparation_kit/search/swap_nodes_algo.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,14 @@ function swapNodes(indexes, queries) {
104104

105105
nodeCollector = Object.fromEntries(
106106
Object.entries(nodeCollector).sort(
107-
([a], [b]) => parseInt(a, __RADIX__) - parseInt(b, __RADIX__)
107+
([a], [b]) =>
108+
Number.parseInt(a, __RADIX__) - Number.parseInt(b, __RADIX__)
108109
)
109110
);
110111

111112
for (const query of queries) {
112113
for (const [level, nodeList] of Object.entries(nodeCollector)) {
113-
const tLevel = parseInt(level, __RADIX__);
114+
const tLevel = Number.parseInt(level, __RADIX__);
114115

115116
if (tLevel % query === 0) {
116117
for (const node of nodeList) {

src/hackerrank/interview_preparation_kit/string_manipulation/sherlock_and_valid_string.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ function isValidCompute(s) {
3434
);
3535
const __RADIX__ = 10;
3636
const __TOLERANCE__ = 1;
37-
const minorFreq = parseInt(frequenciesList[0][0], __RADIX__);
38-
const majorFreq = parseInt(frequenciesList[1][0], __RADIX__);
37+
const minorFreq = Number.parseInt(frequenciesList[0][0], __RADIX__);
38+
const majorFreq = Number.parseInt(frequenciesList[1][0], __RADIX__);
3939

4040
if (
4141
frequencies[minorFreq] === __TOLERANCE__ &&

src/hackerrank/warmup/solveMeFirst.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ function solveMeFirst(inputLines) {
77
const radix = 10;
88

99
inputLines.forEach((v) => {
10-
result += parseInt(v, radix);
10+
result += Number.parseInt(v, radix);
1111
});
1212

1313
return result;

src/hackerrank/warmup/timeConversion.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ function timeConversion(s) {
88

99
const timeStr = s.substring(0, s.length - 2);
1010
const time = timeStr.split(':');
11-
let hour = parseInt(time[0], 10);
11+
let hour = Number.parseInt(time[0], 10);
1212

1313
if (hour >= 12) {
1414
hour = 0;

src/projecteuler/helpers/bigNumbers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ export const bigNum = (strNumber, base = 10) => {
33
let i;
44

55
for (i = 0; i < strNumber.length; i++) {
6-
result.push(parseInt(strNumber.charAt(i), base));
6+
result.push(Number.parseInt(strNumber.charAt(i), base));
77
}
88

99
return result;

0 commit comments

Comments
 (0)