-
Notifications
You must be signed in to change notification settings - Fork 937
Replace tracing::debug! with debug! same for other levels #8300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
|
Good call, just needs to pass CI |
|
Hi @dapplion, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've pushed the trivial import fixes.
Merge Queue Status
🚫 The pull request has left the queue (rule: This pull request spent 33 minutes 39 seconds in the queue, including 31 minutes 40 seconds waiting for CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
ec92aaa to
c90e947
Compare
Merge Queue Status
🚫 The pull request has left the queue (rule: This pull request spent 29 seconds in the queue, with no time waiting for CI. ReasonPull request #8300 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
c90e947 to
b60182e
Compare
|
Oops, my previous unstable merge commit was borked (not sure what happened there), I just did another push. Will wait for CI to complete. |
|
Some required checks have failed. Could you please take a look @dapplion? 🙏 |
Issue Addressed
Just visual clean-up, making logging statements look uniform. There's no reason to use
tracing::debuginstead ofdebug. If we ever need to migrate our logging lib in the future it would make things easier too.