Skip to content

Conversation

@dapplion
Copy link
Collaborator

Issue Addressed

Just visual clean-up, making logging statements look uniform. There's no reason to use tracing::debug instead of debug. If we ever need to migrate our logging lib in the future it would make things easier too.

@dapplion dapplion requested a review from jxs as a code owner October 27, 2025 10:01
@michaelsproul michaelsproul added code-quality waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 27, 2025
@michaelsproul
Copy link
Member

Good call, just needs to pass CI

@mergify mergify bot closed this Nov 26, 2025
@mergify
Copy link

mergify bot commented Nov 26, 2025

Hi @dapplion, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.

@mergify mergify bot added the stale Stale PRs that have been inactive and is now outdated label Nov 26, 2025
@jimmygchen jimmygchen reopened this Nov 28, 2025
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. stale Stale PRs that have been inactive and is now outdated labels Nov 28, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've pushed the trivial import fixes.

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 28, 2025
@mergify
Copy link

mergify bot commented Nov 28, 2025

Merge Queue Status Beta

🚫 The pull request has left the queue (rule: default)

This pull request spent 33 minutes 39 seconds in the queue, including 31 minutes 40 seconds waiting for CI.
The checks were run on draft #8492.

Required conditions to merge
  • check-success=test-suite-success
  • check-success=local-testnet-success

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added the queued label Nov 28, 2025
mergify bot added a commit that referenced this pull request Nov 28, 2025
mergify bot added a commit that referenced this pull request Nov 28, 2025
@mergify mergify bot added dequeued and removed queued labels Nov 28, 2025
@mergify mergify bot removed the dequeued label Nov 28, 2025
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Nov 28, 2025
@mergify
Copy link

mergify bot commented Nov 28, 2025

Merge Queue Status Beta

🚫 The pull request has left the queue (rule: default)

This pull request spent 29 seconds in the queue, with no time waiting for CI.

Reason

Pull request #8300 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • label=ready-for-merge

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@jimmygchen
Copy link
Member

Oops, my previous unstable merge commit was borked (not sure what happened there), I just did another push. Will wait for CI to complete.

@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 28, 2025
@mergify
Copy link

mergify bot commented Nov 28, 2025

Some required checks have failed. Could you please take a look @dapplion? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-review The code is ready for review and removed ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants