-
Notifications
You must be signed in to change notification settings - Fork 937
chore: Add Dockerfile.dev for local development #8295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| FROM rust:1.88.0-bullseye AS builder | ||
| RUN apt-get update && apt-get -y upgrade && apt-get install -y cmake libclang-dev | ||
| WORKDIR /lighthouse | ||
|
|
||
| ARG FEATURES | ||
| ARG PROFILE=release | ||
| ARG CARGO_USE_GIT_CLI=true | ||
| ENV FEATURES=$FEATURES | ||
| ENV PROFILE=$PROFILE | ||
| ENV CARGO_NET_GIT_FETCH_WITH_CLI=$CARGO_USE_GIT_CLI | ||
| ENV CARGO_INCREMENTAL=1 | ||
|
|
||
| COPY . . | ||
| # Persist the registry and target file across builds. See: https://docs.docker.com/build/cache/optimize/#use-cache-mounts | ||
| RUN --mount=type=cache,target=/usr/local/cargo/registry \ | ||
| --mount=type=cache,target=/lighthouse/target \ | ||
| make | ||
|
|
||
| FROM ubuntu:22.04 | ||
| RUN apt-get update && apt-get -y upgrade && apt-get install -y --no-install-recommends \ | ||
| libssl-dev \ | ||
| ca-certificates \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| COPY --from=builder /usr/local/cargo/bin/lighthouse /usr/local/bin/lighthouse | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice I've used this a few times and it seems to have improved. (My machine is slow so I haven't really got enough iterations for measurements)
I noticed the link you provided also suggests mounting this directory, should we include it too?
/usr/local/cargo/git/dbThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah so this caches the bare git repos and commits etc, so likely not much time savings in terms of computation. I think we can experiment using this version - I'll make a PR to update the startup script to use this doclerfile.