Skip to content

Conversation

@bundasmanu
Copy link

At this point, we can only handle the fire of DETECTED_SPEECH events, by setting fire_asr_events in the channel.

This works, but its not feasible, if we want to fire the events always and for all channels.


So, in this PR, it was introduced a logic that:

  • Allows the fire of DETECTED_SPEECH events if fire_asr_events is setted as a global var;
  • The remaining logic was kept as is;
    • If we don't have the global var setted, the channel check for fire_asr_events is done;

Tests:

Oh, yes.

  • global var and channel var not setted;
    • Events not fired;
  • channel var setted to true:
    • Events fired;
  • Global var setted to true:
    • Events fired;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant